Identify timelines uniquely by name (ignore type) #9097
Merged
+1,029
−871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
force-pushed
the
emilk/time-name-key
branch
from
e8fbb06 to
3fb8ac0
Compare
emilk
added
⛃ re_datastore
emilk
changed the title
emilk
force-pushed
the
emilk/time-name-key
branch
from
3fb8ac0 to
6f8fcec
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13452045034 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13452501275 |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
teh-cmc
approved these changes
Feb 21, 2025
Comment on lines
+201
to
+202
| "{:?} ({})", | ||
| self.time_range(), |
There was a problem hiding this comment.
Are these changes gonna make debug dumps harder to read? 😞 I don't remember what the raw debug formatting of a TimeRange looks like...
|
This probably needs a sibling PR on dataplatform, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
We used to uniquely identify a time column by its name and type (temporal or sequence).
This PR changes this to only use the name.
Using the same name but different types has always been undefined behavior, and a bad idea. If you've been doing this, it is likely that your old code already produced "surprising" results. After this PR, you should at least get a clear warning printed in the terminal.
What changed
What happens when you mix different time types on the same timeline?
Both the SDK and the viewer will log a warning, and the last used
TimeTypewill be used in the UI.TODO:
Future PR
TimePoint