-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-email): added a theme switcher to the dev preview #1749
base: canary
Are you sure you want to change the base?
Conversation
|
@KayleeWilliams is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for this! We were already planning on having something similar implemented, so this is a good starting point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few changes, not a lot, just some implementation details
Made some tweaks, changed it to the iFrame as suggested but removed the Theme Provider entirely as it was just doing the same job as the search params, so wasn't necessary. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
66c5ab9
to
9f5b6d3
Compare
bf3f899
to
1748335
Compare
I added a theme switcher to the developer preview. This should allow for an easier/more convient time when designing emails to look good in both light & dark environments.
This only sets the color scheme in the CSS. The actual email will still need to add support whether using Talwind's
dark:
attribute or setting it in the style.Below is an altered version of the Vercel example which has dark-mode support (except the logo)
Screen.Recording.2024-10-29.at.23.24.11.mov