Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-email): added a theme switcher to the dev preview #1749

Open
wants to merge 9 commits into
base: canary
Choose a base branch
from

Conversation

KayleeWilliams
Copy link

@KayleeWilliams KayleeWilliams commented Oct 29, 2024

I added a theme switcher to the developer preview. This should allow for an easier/more convient time when designing emails to look good in both light & dark environments.

This only sets the color scheme in the CSS. The actual email will still need to add support whether using Talwind's dark: attribute or setting it in the style.

Below is an altered version of the Vercel example which has dark-mode support (except the logo)

Screen.Recording.2024-10-29.at.23.24.11.mov

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: be2bc44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 29, 2024

@KayleeWilliams is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@gabrielmfern
Copy link
Collaborator

Thanks for this! We were already planning on having something similar implemented, so this is a good starting point.

@gabrielmfern gabrielmfern added Package: react-email This is the CLI we generally use as just `email` on the temrinal. App: Preview labels Oct 31, 2024
Copy link
Collaborator

@gabrielmfern gabrielmfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few changes, not a lot, just some implementation details

@KayleeWilliams
Copy link
Author

Requested a few changes, not a lot, just some implementation details

Made some tweaks, changed it to the iFrame as suggested but removed the Theme Provider entirely as it was just doing the same job as the search params, so wasn't necessary.

renovate bot and others added 5 commits November 4, 2024 14:17
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: Preview Package: react-email This is the CLI we generally use as just `email` on the temrinal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants