fix(render): Prettier breaking if mso comments #1839
Merged
+70
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bec4b32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
bf3f899 to
1748335
Compare
vcapretz
approved these changes
Jan 22, 2025
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
a8d97ed to
d36385e
Compare
gabrielmfern
force-pushed
the
fix/prettier-render-problems
branch
2 times, most recently
from
d25270f to
92107b5
Compare
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
…ame as the source code
gabrielmfern
force-pushed
the
fix/prettier-render-problems
branch
from
6f56e11 to
bec4b32
Compare
gabrielmfern
added a commit
that referenced
this pull request
Jan 22, 2025
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Bu Kinoshita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gabrielmfern
added a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Bu Kinoshita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gabrielmfern
added a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Bu Kinoshita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gabrielmfern
added a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Bu Kinoshita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant for #1813.
The issue is that comments, like the one below, would become formatted in such a way that would make Outlook
not properly detect the conditional comment, and thus not render in Outlook.
To fix this issue, this PR proposes that we firstly modify the
htmlprettier plugin in such a way that it always ignoresif msocomments like these. This isn't very hard at all, since the parser for the plugin already has a node type forieConditionalComments.