Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub CI actions #15

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Conversation

tpltnt
Copy link
Contributor

@tpltnt tpltnt commented Apr 11, 2021

Hi there,

I added github actions to build and test the id server. I also removed the travis config to address issue #9.

Cheers,
tpltnt

@angusmcleod
Copy link
Member

@tpltnt Great! Thanks for starting this. Does it make sense to address resonatecoop/id#12 at the same time?

@angusmcleod angusmcleod self-requested a review April 13, 2021 09:58
@tpltnt
Copy link
Contributor Author

tpltnt commented Apr 16, 2021

I would do a separate PR, just to keep the issue lists and branches clean.

@angusmcleod
Copy link
Member

@auggod Hey :) This looks like a good step forward to me. Just want to check if you're ok with this?

@auggod
Copy link
Member

auggod commented Apr 20, 2021

@angusmcleod I never used github actions before but I assume this is risk free to enable this at this point.

@auggod auggod merged commit 06a0b3c into resonatecoop:develop Apr 20, 2021
@tpltnt tpltnt deleted the issue-9-github-actions-ci branch April 21, 2021 12:19
@tpltnt tpltnt mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants