chore: reworked logger init #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole logger setup is kinda silly, and was primarially silly because a logger was not initialized until after the config was parsed for debug handling. Now setting the logger to a default value, and redefine it later once config is parsed. There is also no reason to call initLogger and initConfig in additional commands with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole logger setup is kinda silly, and was primarially silly because a logger was not initialized until after the config was parsed for debug handling.
Now setting the logger to a default value, and redefine it later once config is parsed.
There is also no reason to call initLogger and initConfig in additional commands with this change.