update default configuration and fix number field line number start

riccardoperra · Apr 27, 2024 · 91ce749 · 91ce749
1 parent a8accc6
commit 91ce749
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/apps/codeimage/src/components/PropertyEditor/EditorStyleForm.tsx b/apps/codeimage/src/components/PropertyEditor/EditorStyleForm.tsx
@@ -230,6 +230,9 @@ export const EditorStyleForm: ParentComponent = () => {
                       max={lineNumbersConfig.max}
                       id={'frameLineNumberStartField'}
                       value={editor().lineNumberStart}
+                      ref={el => {
+                        el.autocomplete = 'off';
+                      }}
                       onChange={setLineNumberStart}
                     />
                   </SuspenseEditorItem>

diff --git a/apps/codeimage/src/state/editor/activeEditor.ts b/apps/codeimage/src/state/editor/activeEditor.ts
@@ -48,13 +48,15 @@ const $activeEditorState = () => {
       setEditors(currentEditorIndex(), 'code', code);
 
     const setLineNumberStart = (lineNumberStart: number | null | undefined) => {
-      if (lineNumberStart === null) return;
+      if (!lineNumberStart) {
+        lineNumberStart = 1;
+      }
       return setEditors(
         currentEditorIndex(),
         'lineNumberStart',
         // TODO Already done by @codeui/kit but I don't feel safe about this component I made
         clamp(
-          lineNumberStart ?? 1,
+          lineNumberStart,
           appEnvironment.lineNumbers.min,
           appEnvironment.lineNumbers.max,
         ),