various changes

README.md

@@ -39,39 +39,43 @@ appended to the name of the LV when the snapshot is created.
 
 If before running the role, the following LVs exist:
 
-  LV      VG   Attr       LSize   Pool Origin Data%  Meta%  Move Log Cpy%Sync Convert
-  home    rhel -wi-ao----   1.00g
-  root    rhel -wi-ao----  35.00g
-  swap    rhel -wi-ao----  <3.88g
-  lv1_vg1 vg1  -wi-a-----   1.00g
-  lv2_vg1 vg1  -wi-a-----  40.00m
-  lv1_vg2 vg2  -wi-a-----   1.00g
-  lv2_vg2 vg2  -wi-a-----  80.00m
-  lv1_vg3 vg3  -wi-a-----   1.00g
-  lv3_vg3 vg3  -wi-a----- 120.00m
+```
+LV      VG   Attr       LSize   Pool Origin Data%  Meta%  Move Log Cpy%Sync Convert
+home    rhel -wi-ao----   1.00g
+root    rhel -wi-ao----  35.00g
+swap    rhel -wi-ao----  <3.88g
+lv1_vg1 vg1  -wi-a-----   1.00g
+lv2_vg1 vg1  -wi-a-----  40.00m
+lv1_vg2 vg2  -wi-a-----   1.00g
+lv2_vg2 vg2  -wi-a-----  80.00m
+lv1_vg3 vg3  -wi-a-----   1.00g
+lv3_vg3 vg3  -wi-a----- 120.00m
+```
 
 If the prefix is set to "a_" and the suffix is set to "_z", running the role will result
 in the following:
 
-  LV          VG   Attr       LSize   Pool Origin  Data%  Meta%  Move Log Cpy%Sync Convert
-  a_home_z    rhel swi-a-s--- 104.00m      home    0.00
-  a_root_z    rhel swi-a-s---   3.50g      root    0.01
-  a_swap_z    rhel swi-a-s--- 400.00m      swap    0.00
-  home        rhel owi-aos---   1.00g
-  root        rhel owi-aos---  35.00g
-  swap        rhel owi-aos---  <3.88g
-  a_lv1_vg1_z vg1  swi-a-s--- 104.00m      lv1_vg1 0.00
-  a_lv2_vg1_z vg1  swi-a-s---   8.00m      lv2_vg1 0.00
-  lv1_vg1     vg1  owi-a-s---   1.00g
-  lv2_vg1     vg1  owi-a-s---  40.00m
-  a_lv1_vg2_z vg2  swi-a-s--- 104.00m      lv1_vg2 0.00
-  a_lv2_vg2_z vg2  swi-a-s---  12.00m      lv2_vg2 0.00
-  lv1_vg2     vg2  owi-a-s---   1.00g
-  lv2_vg2     vg2  owi-a-s---  80.00m
-  a_lv1_vg3_z vg3  swi-a-s--- 104.00m      lv1_vg3 0.00
-  a_lv3_vg3_z vg3  swi-a-s---  16.00m      lv3_vg3 0.00
-  lv1_vg3     vg3  owi-a-s---   1.00g
-  lv3_vg3     vg3  owi-a-s--- 120.00m
+```
+LV          VG   Attr       LSize   Pool Origin  Data%  Meta%  Move Log Cpy%Sync Convert
+a_home_z    rhel swi-a-s--- 104.00m      home    0.00
+a_root_z    rhel swi-a-s---   3.50g      root    0.01
+a_swap_z    rhel swi-a-s--- 400.00m      swap    0.00
+home        rhel owi-aos---   1.00g
+root        rhel owi-aos---  35.00g
+swap        rhel owi-aos---  <3.88g
+a_lv1_vg1_z vg1  swi-a-s--- 104.00m      lv1_vg1 0.00
+a_lv2_vg1_z vg1  swi-a-s---   8.00m      lv2_vg1 0.00
+lv1_vg1     vg1  owi-a-s---   1.00g
+lv2_vg1     vg1  owi-a-s---  40.00m
+a_lv1_vg2_z vg2  swi-a-s--- 104.00m      lv1_vg2 0.00
+a_lv2_vg2_z vg2  swi-a-s---  12.00m      lv2_vg2 0.00
+lv1_vg2     vg2  owi-a-s---   1.00g
+lv2_vg2     vg2  owi-a-s---  80.00m
+a_lv1_vg3_z vg3  swi-a-s--- 104.00m      lv1_vg3 0.00
+a_lv3_vg3_z vg3  swi-a-s---  16.00m      lv3_vg3 0.00
+lv1_vg3     vg3  owi-a-s---   1.00g
+lv3_vg3     vg3  owi-a-s--- 120.00m
+```
 
 ### snapshot_lvm_percent_space_required
 
@@ -85,8 +89,8 @@ Note: LVM will round up size to full physical extent
 
 ### snapshot_lvm_all_vgs
 
-This is required the default is true.  If true the role will snapshot all VGs on the
-target system.
+This is a boolean value with default false.  If true the role will snapshot
+all VGs on the target system.
 
 ### snapshot_lvm_vg
 

tasks/check_space.yml

@@ -5,6 +5,6 @@
     -p {{ snapshot_lvm_prefix | quote }} -s {{ snapshot_lvm_suffix | quote }}
   register: snapshot_cmd
   args:
-    executable: "{{ ansible_python.executable }}"
+    executable: "{{ __snapshot_python }}"
   failed_when:
     snapshot_cmd.rc != 0

tasks/cleanup.yml

@@ -5,7 +5,7 @@
     snapshot.py clean -a -p {{ snapshot_lvm_prefix | quote }}
     -s {{ snapshot_lvm_suffix | quote }}
   args:
-    executable: "{{ ansible_python.executable }}"
+    executable: "{{ __snapshot_python }}"
   register: snapshot_cmd
   failed_when:
     snapshot_cmd.rc != 0

tasks/snapshot_all.yml

@@ -2,7 +2,7 @@
 - name: Snapshot All VGs
   ansible.builtin.script: "{{ __cmd }}"
   args:
-    executable: "{{ ansible_python.executable }}"
+    executable: "{{ __snapshot_python }}"
   register: snapshot_cmd
   vars:
     __cmd: "{{ 'snapshot.py snapshot ' ~

tasks/verify_cleanup.yml

@@ -2,7 +2,7 @@
 - name: Verify snapshot clean is completed
   ansible.builtin.script: "{{ __cmd }}"
   args:
-    executable: "{{ ansible_python.executable }}"
+    executable: "{{ __snapshot_python }}"
   register: snapshot_cmd
   vars:
     __cmd: "{{ 'snapshot.py clean ' ~

tasks/verify_complete.yml

@@ -2,7 +2,7 @@
 - name: Verify snapshots are completed
   ansible.builtin.script: "{{ __cmd }}"
   args:
-    executable: "{{ ansible_python.executable }}"
+    executable: "{{ __snapshot_python }}"
   register: snapshot_cmd
   vars:
     __cmd: "{{ 'snapshot.py check ' ~

tests/tests_default.yml

@@ -3,11 +3,10 @@
 - name: Ensure that the role runs with default parameters
   hosts: all
   gather_facts: false  # test that role works in this case
+  vars:
+    snapshot_lvm_action: check
+    snapshot_lvm_percent_space_required: 1
+    snapshot_lvm_prefix: a_
+    snapshot_lvm_suffix: _z
   roles:
     - linux-system-roles.snapshot
-  tasks:
-    - name: Check header for ansible_managed, fingerprint
-      include_tasks: tasks/check_header.yml
-      vars:
-        __file: /etc/snapshot.conf
-        __fingerprint: system_role:snapshot

vars/main.yml

@@ -3,6 +3,8 @@
 
 __snapshot_packages: ["lvm2"]
 __snapshot_services: []
+# python to use on managed nodes for snapshot.py
+__snapshot_python: /usr/bin/python3
 # ansible_facts required by the role
 __snapshot_required_facts:
   - distribution