Add fix to release-1.1
#266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display the complete error chain for EVM errors. Previously, the root cause, such as network problems, was hidden.
This fixes the current compilation errors.
Previously, we used to use `revm::primitives::HashMap` to have the same
hash in Steel and `revm`. However, with the latest (minor) revm version,
this has been switched to using `alloy_primitves::map::HashMap`. Thus,
in this PR we also replace all `{Hash,BTree}{Map,Set}` with their more
performant and specific equivalent in `alloy_primitives::map`.
### Additional context
- alloy-rs/alloy#1365
Fix clippy warnings form the latest toolchain. Co-authored-by: Victor Graf <[email protected]>
With the change from `ethers` to `alloy`, we made an error in assuming they'd handle ABI encoding of `Vec<_>` the same. This broke the `prove` cheatcode that is used in the Foundry template tests. We did not catch this error prior to releasing, because we had moved all our tests in this repo over to using `RiscZeroMockVerifier.mockProve` instead and forgot to add test coverage specifically for this cheatcode. This PR fixes the encoding issue and additionally adds a simple test for using `risc0-forge-ffi` in dev mode. Additionally, this PR solves a problem where the FFI cheatcode would fail if `RUST_LOG` is set. --------- Co-authored-by: Wolfgang Welz <[email protected]>
capossele
approved these changes
Oct 1, 2024
|
blocked by #274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds #254 to release-1.1