WEB3-282: feat: Allow querying blocks by hash #416
Conversation
github-actions
bot
changed the title
crates/steel/src/host/builder.rs
Outdated
There was a problem hiding this comment.
For the (unstable) history feature we only have the method commitment_block(self, BlockNumberOrTag).
Should we make this consistent with block_number, block_number_or_tag, block_hash for the execution block? Or would that complicate the API unnecessarily (related to WEB3-272)
There was a problem hiding this comment.
It's a balance for sure, but if possible that would be beneficial. Block hashes may be preferred in some situations, since they are unambiguous (incl in contexts where multiple chains may be referred to, or in a context where reorgs must be handled). It's also not the end of the world to say they need to get the block number and pass that in instead 🤷
There was a problem hiding this comment.
Added the missing methods in cca36da
crates/steel/src/host/builder.rs
Outdated
There was a problem hiding this comment.
It's a balance for sure, but if possible that would be beneficial. Block hashes may be preferred in some situations, since they are unambiguous (incl in contexts where multiple chains may be referred to, or in a context where reorgs must be handled). It's also not the end of the world to say they need to get the block number and pass that in instead 🤷
Co-authored-by: Victor Snyder-Graf <[email protected]>
Fixes #384 and WEB3-282