ZIR-294: [WIP] Add wide join and join+lift programs #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an EmitRecursion pass to wrap emitRecursion to generate zkrs that the pass manager can run in parallel * Enable parallelism in EDSL context * (Incidental change: update hedron to fix clangd indexing)
…to victor/fat-join
github-actions
bot
changed the title
* Move sortForReproducibility to a MLIR pass to allow for parallelism * Decrease memory usage when deterministically sorting EDSL operations by only caching property info when needed * Clean up compile warnings in TypeUtils.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to risc0/risc0#2657, this PR adds recursion program implementations for wide join and (wide) lift+join programs.
As of yet, I have not been able to get code generation to complete. The current implementations has a total of 189 programs, due to generating the cross-product of join widths and a range of po2s which, was fixed at the value 18 before. Nils, did some work to parallelize the compilation process, which is included in this branch. That has not yet resolved the issue.