This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Proposal: Make Zvfh to depend on Zvfhmin instead of Zve32f
#911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although that this is functionally equivalent (since 'Zvfhmin' implies 'Zve32f'), it makes clearer that 'Zvfh' is a strict superset of 'Zvfhmin'. Signed-off-by: Tsukasa OI <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although that this is functionally equivalent (since
Zvfhmindepends onZve32f), it makes clearer thatZvfhis a strict superset ofZvfhmin.Again, it will not change the contents of both extensions.
But I believe that this change will ease some developers that depend on the expanded ISA string (e.g. after expanding
G→IMAFD_Zicsr_Zifencei) or similar data structure (like which QEMU uses) because if we need to probe the vector FP16 conversion capability, we just need to probe for theZvfhminextension, notZvfhminorZvfh.