feat(snapshot): persist snapshot backfill epoch in fragment stream node #19751
+208
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously in snapshot backfill, we don't persist the epoch on which we read the snapshot, because we didn't have to support recoverable snapshot backfill yet, and we only need to store the epoch in memory, and when recovery happens, either the snapshot backfill is finished, or the job is removed and clean. But to support recoverable snapshot backfill, we may need to persist the snapshot epoch so that we can obtain the snapshot epoch after recovery.
In this PR, we will store the snapshot backfill epoch in the
StreamScanNode
. In frontend when the node is just created, the epoch field isNone
. The snapshot backfill epoch is later filled by the global barrier worker when handling the command. When streaming job with snapshot backfill is being created, we will fill the latest upstream epoch to the field before sending it to CN local barrier manager. When the first barrier to create the job is collected and committed, we will update the fragment info in catalog in thepost_collect
method ofCommand
so that when recovery happened, we can still read the filled snapshot backfill epoch.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.