Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snapshot): persist snapshot backfill epoch in fragment stream node #19751

Merged
merged 4 commits into from
Dec 25, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Dec 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously in snapshot backfill, we don't persist the epoch on which we read the snapshot, because we didn't have to support recoverable snapshot backfill yet, and we only need to store the epoch in memory, and when recovery happens, either the snapshot backfill is finished, or the job is removed and clean. But to support recoverable snapshot backfill, we may need to persist the snapshot epoch so that we can obtain the snapshot epoch after recovery.

In this PR, we will store the snapshot backfill epoch in the StreamScanNode. In frontend when the node is just created, the epoch field is None. The snapshot backfill epoch is later filled by the global barrier worker when handling the command. When streaming job with snapshot backfill is being created, we will fill the latest upstream epoch to the field before sending it to CN local barrier manager. When the first barrier to create the job is collected and committed, we will update the fragment info in catalog in the post_collect method of Command so that when recovery happened, we can still read the filled snapshot backfill epoch.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 force-pushed the yiming/store-snapshot-backfill-epoch-in-node branch from 7b34a4e to 801570a Compare December 11, 2024 09:35
@wenym1 wenym1 changed the base branch from main to yiming/fix-snapshot-backfill-extra-recv December 11, 2024 09:36
@graphite-app graphite-app bot requested a review from a team December 11, 2024 09:36
Copy link
Contributor Author

wenym1 commented Dec 11, 2024

Base automatically changed from yiming/fix-snapshot-backfill-extra-recv to main December 12, 2024 07:03
@wenym1 wenym1 force-pushed the yiming/store-snapshot-backfill-epoch-in-node branch from 801570a to 122cda8 Compare December 12, 2024 07:59
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/meta/src/barrier/command.rs Outdated Show resolved Hide resolved
@wenym1 wenym1 added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit ae48d9d Dec 25, 2024
37 of 38 checks passed
@wenym1 wenym1 deleted the yiming/store-snapshot-backfill-epoch-in-node branch December 25, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants