feat(sink): support force_append_only for es sink #19919
+61
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Why do we need this PR? Isn't force_append_only already been handled in the sink executor before reaching the specific sink implementation:
risingwave/src/stream/src/executor/sink.rs
Line 466 in bdee34e
| @@ -79,13 +81,14 @@ impl StreamChunkConverter { | |||
|
|
|||
| pub fn convert_chunk(&self, chunk: StreamChunk) -> Result<StreamChunk> { | |||
| match self { | |||
| StreamChunkConverter::Es(es) => es.convert_chunk(chunk), | |||
| StreamChunkConverter::Es(es) => es.convert_chunk(chunk,es.is_append_only), | |||
| @@ -117,7 +121,7 @@ impl EsStreamChunkConverter { | |||
| <Utf8ArrayBuilder as risingwave_common::array::ArrayBuilder>::new(chunk.capacity()); | |||
| let mut routing_builder = | |||
| <Utf8ArrayBuilder as risingwave_common::array::ArrayBuilder>::new(chunk.capacity()); | |||
| for build_bulk_para in self.formatter.convert_chunk(chunk)? { | |||
| for build_bulk_para in self.formatter.convert_chunk(chunk,is_append_only)? { | |||
| @@ -202,7 +205,7 @@ impl AsyncTruncateSinkWriter for ElasticSearchOpenSearchSinkWriter { | |||
| let mut bulks: Vec<ElasticSearchOpenSearchBulk> = Vec::with_capacity(chunk_capacity); | |||
|
|
|||
| let mut bulks_size = 0; | |||
| for build_bulk_para in self.formatter.convert_chunk(chunk)? { | |||
| for build_bulk_para in self.formatter.convert_chunk(chunk,self.is_append_only)? { | |||
| @@ -113,7 +113,7 @@ impl ElasticSearchOpenSearchFormatter { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn convert_chunk(&self, chunk: StreamChunk) -> Result<Vec<BuildBulkPara>> { | |||
| pub fn convert_chunk(&self, chunk: StreamChunk,is_append_only: bool) -> Result<Vec<BuildBulkPara>> { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
We didn't support type for es sink, and this pr support it like other sink
Checklist
Documentation
Release note