Use puckBearingEnabled prop in Android #3742

RmStorm · 2025-01-17T13:05:30Z

Description

Fixes #3391

I've read CONTRIBUTING.md
I updated the doc/other generated code with running yarn generate in the root folder
I have tested the new feature on /example app.
- In V11 mode/ios
- In New Architecture mode/ios
- In V11 mode/android
- In New Architecture mode/android

yarn generate throws with a completely unrelated error that I do not have time to debug.

android/src/main/java/com/rnmapbox/rnmbx/components/location/RNMBXNativeUserLocation.kt

RmStorm · 2025-01-27T09:24:45Z

android/src/main/java/com/rnmapbox/rnmbx/components/location/RNMBXNativeUserLocation.kt

+        set(value) {
+            field = value
+            _apply()
+        }


This is necessary for hot reloading to work on this property.

Use puckBearingEnabled prop in Android

91d2e35

RmStorm had a problem deploying to CI with Mapbox Tokens January 17, 2025 13:05 — with GitHub Actions Error

mfazekas reviewed Jan 27, 2025

View reviewed changes

android/src/main/java/com/rnmapbox/rnmbx/components/location/RNMBXNativeUserLocation.kt Outdated Show resolved Hide resolved

RmStorm had a problem deploying to CI with Mapbox Tokens January 27, 2025 09:21 — with GitHub Actions Error

RmStorm force-pushed the fix-android-locationpuck-bearing branch from 6e60469 to 4c480c7 Compare January 27, 2025 09:23

RmStorm had a problem deploying to CI with Mapbox Tokens January 27, 2025 09:23 — with GitHub Actions Error

RmStorm commented Jan 27, 2025

View reviewed changes

Give androidRenderMode precedence when determing rendering

52ff3f4

RmStorm force-pushed the fix-android-locationpuck-bearing branch from 4c480c7 to 52ff3f4 Compare January 27, 2025 09:29

RmStorm requested a deployment to CI with Mapbox Tokens January 27, 2025 09:29 — with GitHub Actions Waiting

RmStorm requested a deployment to CI with Mapbox Tokens January 27, 2025 09:29 — with GitHub Actions Queued

RmStorm requested a deployment to CI with Mapbox Tokens January 27, 2025 09:29 — with GitHub Actions Waiting

RmStorm requested a deployment to CI with Mapbox Tokens January 27, 2025 09:29 — with GitHub Actions Queued

RmStorm requested a review from mfazekas January 27, 2025 10:03