Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): support RN 0.77 #3749

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

efstathiosntonas
Copy link

@efstathiosntonas efstathiosntonas commented Jan 23, 2025

Description

adds support for [email protected] on Android, iOS builds fine.

LayoutShadowNode was introduced on [email protected]

fixes #3753

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • [] I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

@efstathiosntonas efstathiosntonas temporarily deployed to CI with Mapbox Tokens January 23, 2025 13:39 — with GitHub Actions Inactive
@efstathiosntonas efstathiosntonas temporarily deployed to CI with Mapbox Tokens January 23, 2025 13:39 — with GitHub Actions Inactive
@efstathiosntonas efstathiosntonas deployed to CI with Mapbox Tokens January 23, 2025 13:39 — with GitHub Actions Active
@efstathiosntonas efstathiosntonas temporarily deployed to CI with Mapbox Tokens January 23, 2025 13:39 — with GitHub Actions Inactive
@efstathiosntonas efstathiosntonas temporarily deployed to CI with Mapbox Tokens January 23, 2025 13:39 — with GitHub Actions Inactive
@efstathiosntonas efstathiosntonas temporarily deployed to CI with Mapbox Tokens January 23, 2025 13:39 — with GitHub Actions Inactive
@efstathiosntonas efstathiosntonas temporarily deployed to CI with Mapbox Tokens January 23, 2025 13:39 — with GitHub Actions Inactive
@efstathiosntonas
Copy link
Author

efstathiosntonas commented Jan 23, 2025

@mfazekas since ReadableArray is now optional: https://reactnative.dev/blog/2025/01/21/version-0.77#android several changes needs to take place. How we should proceed from here?

On package.json the minimum version "react-native": ">=0.59.9", is this still possible 🤔 ? What is the minimum react-native version supported? Asking because LayoutShadowNode was introduced on [email protected] and it's a requirement on 0.77.

@mfazekas
Copy link
Contributor

@mfazekas since ReadableArray is now optional: https://reactnative.dev/blog/2025/01/21/version-0.77#android several changes needs to take place. How we should proceed from here?

On package.json the minimum version "react-native": ">=0.59.9", is this still possible 🤔 ? What is the minimum react-native version supported? Asking because LayoutShadowNode was introduced on [email protected] and it's a requirement on 0.77.

@efstathiosntonas thanks much for looking into it. We can bump and should bump min version to 0.72.

@mfazekas
Copy link
Contributor

@efstathiosntonas question, have you reread those generated code with 0.77? Or you've modified the code by hand?

@efstathiosntonas
Copy link
Author

Yes, I've modified by hand and tested them on my app while running 0.77.

The logs from them linked issue are half way there, if you get past these errors then the errors about BaseViewManagerInterface start to kick in.

@efstathiosntonas
Copy link
Author

@mfazekas I would like your help in fixing the optional ReadableArray, the logs from the linked issue got all the info we need. Can you pleaaaaaaase pick up from here?

@efstathiosntonas
Copy link
Author

efstathiosntonas commented Jan 27, 2025

@mfazekas if you're wondering where the delegators changes came from, all major libraries have applied them to support 0.77, eg. svg

@efstathiosntonas
Copy link
Author

@mfazekas in the latest commit: 9e33682 I've aligned with optional ReadableArray. Please note that the changes are the ones suggested by Android Studio. I've appied the changes withpatch-package on my project/app and it builds fine on 0.77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RN 0.77 support
2 participants