-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : Added workflow support for Llama Vision 3.2 #866
base: main
Are you sure you want to change the base?
Feature : Added workflow support for Llama Vision 3.2 #866
Conversation
Hello @AHB102 ! First of all, thanks for the contribution! Is this PR ready for review? It appears to just rename a few variables but functionally still calls the OpenAI API. When you're ready for review, please add a test as in https://github.com/roboflow/inference/blob/main/tests/workflows/unit_tests/core_steps/models/foundation/test_openai.py Tag me or @PawelPeczek-Roboflow if you have further questions! |
@probicheaux So, I'm still working on this. I'm trying out OpenRouter's Inference API for LLama Vision, which uses an OpenAI client. I've tweaked it a bit, but most of it is based on how OpenAI and Anthropic workflows do things. I opened a PR to get some feedback on what might be wrong. I've also started writing unit tests, but I haven't actually run them yet. I'm a bit stuck on how to test this workflow part. I haven't worked with a codebase this big before, so I'm still learning the ropes. Some things might be a bit off. 😅 |
ok, have taken a look - looks good - I will add test later on this week, looks good, if I did not discover anything I would simply approve |
@AHB102 things are looking good! if you're interested in trying to test it, it is possible to build one of the dockerfiles locally and connect workflows to localhost, or to mock out the response from the openrouter call as in inference/tests/workflows/unit_tests/core_steps/models/foundation/test_openai.py Line 384 in a4e51e2
It sounds like you and @PawelPeczek-Roboflow are in correspondence, so I'll let you two take it from here! |
I am sorry, running out of time this week to handle that - will try to push through finish line next week |
really sorry, got buffer overflow with work on another topics. This would need to wait till after Christmas unfortunately |
@PawelPeczek-Roboflow Hello, I've been unavailable for the past few days due to exams. Is there anything I need to address ? |
Description
Issue : #692
Added a workflow block for Llama Vision 3.2
List any dependencies that are required for this change.
None
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
No testing has been performed
Any specific deployment considerations
Currently, only the Llama Vision 3.2 model workflow block is present. API keys for the model have not been provided.
Docs