Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change download() to not overwrite files by default #213

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

capjamesg
Copy link
Collaborator

Description

This PR changes the download() method to set the overwrite flag to False by default. This will ensure that a dataset is not re-downloaded every time the download() method is run.

This addresses #108.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

Run the following snippet twice:

!pip install roboflow

from roboflow import Roboflow
rf = Roboflow(api_key="")
project = rf.workspace("capjamesg").project("streamlit-logo-detection")
dataset = project.version(1).download("coco")

When you run the code for the first time, a Downloading Dataset Version Zip in message should appear as the dataset is downloaded. On the second run, Downloading Dataset Version Zip in should not appear.

Any specific deployment considerations

N/A

Docs

N/A

Copy link
Collaborator

@tonylampada tonylampada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@capjamesg capjamesg merged commit 9c8f596 into main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants