Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local timezone when query logs & usages for dedicated deployment #341

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

PacificDou
Copy link
Contributor

@PacificDou PacificDou commented Nov 18, 2024

Description

Use local timezone when query logs & usages for dedicated deployment, default is UTC time.

List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Tested locally.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@PacificDou PacificDou requested a review from bigbitbus November 18, 2024 11:26
@PacificDou PacificDou marked this pull request as ready for review November 18, 2024 11:26
@PacificDou PacificDou changed the title Use local timezone when query logs for dedicated deployment Use local timezone when query logs & usages for dedicated deployment Nov 26, 2024
Copy link
Contributor

@bigbitbus bigbitbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the example for ISO

@@ -23,19 +23,19 @@ def check_from_to_timestamp(from_timestamp, to_timestamp, default_timedelta):
print("Please provide a valid to_timestamp in ISO8601 format")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one example so somone can make up the time format correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@PacificDou PacificDou merged commit 7fca4bb into main Nov 28, 2024
1 of 7 checks passed
@PacificDou PacificDou deleted the bugfix-dedicated-deployment-log branch November 28, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants