Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed welcome workflow #1596

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Removed welcome workflow #1596

merged 1 commit into from
Oct 14, 2024

Conversation

LinasKo
Copy link
Contributor

@LinasKo LinasKo commented Oct 14, 2024

Description

It doesn't work, and trip new contributors up

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Untested, but verified no other workflow depends on it.

Any specific deployment considerations

None

Docs

  • Docs updated? What were the changes:

* It doesn't work, and trip new contributors up
@LinasKo LinasKo requested a review from onuralpszr October 14, 2024 10:58
@onuralpszr
Copy link
Collaborator

@LinasKo well let's fix it instead of removing it :)

@LinasKo
Copy link
Contributor Author

LinasKo commented Oct 14, 2024

Spending a long time is not woth it. I compared with other repos, there's a small chance it's a token issue I can't quickly address.

Feel free to make a PR if you wish :)

@onuralpszr
Copy link
Collaborator

Spending a long time is not woth it. I compared with other repos, there's a small chance it's a token issue I can't quickly address.

Feel free to make a PR if you wish :)

Sure, I understand it is not hugely important, I am merging as it is not the hang PR and I will open new PR when I made fix, at least. I will happy to "not see" red X in every new contributor

@onuralpszr onuralpszr merged commit 086091a into develop Oct 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants