Update Header.php #734
Open
Update Header.php #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modification allows you to configure H1 to H5 for the $title while maintaining the existing functionality of the component. <x-header title="My Title" :heading-level="1" /> // This will render an h1 <x-header title="My Title" :heading-level="3" /> // This will render an h3 <x-header title="My Title" /> // This will render an h2 (default)
|
Thanks for this! I am delaying it for now because of upcoming maryUI v2 (daisyUI 5 + Tailwind 4). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification allows you to configure H1 to H5 for the $title while maintaining the existing functionality of the component.
// This will render an h1 // This will render an h3 // This will render an h2 (default)
Let me know if you consider this a breaking change since it sets the title output from a div to a H1-H5 tag.