Update the Kotlin generator to support KMP projects #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerluan
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Amazing contribution like always, thank you so much! ❤️
Just requested some minor improvements but overall this PR is great! 🙌
Let me know if you have any questions 😊 Also, I apologize for taking so long to get to this PR! I completely missed it in my notifications!
rogerluan
approved these changes
Jun 11, 2024
|
Released in https://github.com/rogerluan/arkana/releases/tag/v2.1.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Kotlin Multiplatform support by applying the following updates to the Kotlin generator:
arkana.kt.erbtemplate to ensure the generated Kotlin code is compatible with multiplatform projects by replacing the JVM only functionByteArray#toString(...)with its KMP counterpartByeArray#decodeToString()is_kotlin_multiplatform_moduleas a new yml configuration parameter that changes the generatedbuild.gradlefile andSourceSetfolders to a KMP compatible ones when set totrue.