Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Server Components: Remove Rollbar Context #119

Closed
wants to merge 4 commits into from

Conversation

mudetroit
Copy link
Contributor

Description of the change

React Server Components don't play nicely with Context. So we are removing the dependency on context from our ErrorBoundary

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Notes

This also removes our React Hooks. They are also dependent on context, and looking at them they seem like low value adds. The functionality present can easily be replaced by simply importing Rollbar and then calling the config function. This will require updates to documentation

@mudetroit mudetroit requested review from waltjones and matux March 5, 2024 21:15
@mudetroit
Copy link
Contributor Author

Decided to approach this in a different manner

@mudetroit mudetroit closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant