Fix some rubocop offenses

.simplecov

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 SimpleCov.command_name "spec:#{SPEC_ROOT.join('..').basename}"
 
 SimpleCov.root(SPEC_ROOT.join('../..').to_s)
@@ -6,4 +8,4 @@ SimpleCov.start do
   add_filter '/spec/'
   add_filter '/rom-sql/'
   add_filter '/lint/'
-end
+end

Gemfile

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 gemspec
 
-eval_gemfile "Gemfile.devtools"
+eval_gemfile 'Gemfile.devtools'
 
 unless defined?(COMPONENTS)
-  COMPONENTS = %w(core repository changeset)
+  COMPONENTS = %w[core repository changeset].freeze
 end
 
 COMPONENTS.each do |component|
@@ -23,13 +25,13 @@ if ENV['USE_DRY_INITIALIZER_MAIN'].eql?('true')
 end
 
 group :sql do
-  gem 'sequel', '~> 5.0'
-  gem 'sqlite3', platforms: :ruby
-  gem 'jdbc-sqlite3', platforms: :jruby
-  gem 'jdbc-postgres', platforms: :jruby
-  gem 'pg', platforms: :ruby
   gem 'dry-events', '~> 1.0'
   gem 'dry-monitor', '~> 1.0'
+  gem 'jdbc-postgres', platforms: :jruby
+  gem 'jdbc-sqlite3', platforms: :jruby
+  gem 'pg', platforms: :ruby
+  gem 'sequel', '~> 5.0'
+  gem 'sqlite3', platforms: :ruby
 
   # if ENV['USE_ROM_SQL_MASTER'].eql?('true')
   #   gem 'rom-sql', github: 'rom-rb/rom-sql', branch: 'master'
@@ -40,8 +42,8 @@ group :sql do
 end
 
 group :test do
-  gem 'rspec', '~> 3.6'
   gem 'codacy-coverage', require: false
+  gem 'rspec', '~> 3.6'
   gem 'simplecov', platforms: :ruby
   gem 'warning'
 end
@@ -65,6 +67,6 @@ end
 
 group :benchmarks do
   # gem 'hotch', platforms: :ruby
-  gem 'benchmark-ips'
   gem 'activerecord', '~> 5.0'
+  gem 'benchmark-ips'
 end

Rakefile

@@ -1,10 +1,12 @@
-require "bundler/gem_tasks"
+# frozen_string_literal: true
 
-SPEC_RESULTS = {}
+require 'bundler/gem_tasks'
+
+SPEC_RESULTS = {}.freeze
 
 desc 'Run all specs'
 task :spec do
-  %w(core repository changeset rom).map do |name|
+  %w[core repository changeset rom].map do |name|
     Rake::Task["spec:#{name}"].execute
   end
 
@@ -40,4 +42,4 @@ task default: :spec
 begin
   require 'yard-junk/rake'
   YardJunk::Rake.define_task(:text)
-rescue LoadError;end
+rescue LoadError; end

changeset/lib/rom/changeset/extensions/relation.rb

@@ -11,14 +11,16 @@ module Extensions
       # Changeset extenions for combined relations
       #
       # @api public
-      class Relation::Graph
-        # Build a changeset for a combined relation
-        #
-        # @raise NotImplementedError
-        #
-        # @api public
-        def changeset(*)
-          raise NotImplementedError, "Changeset doesn't support combined relations yet"
+      module Relation
+        class Graph
+          # Build a changeset for a combined relation
+          #
+          # @raise NotImplementedError
+          #
+          # @api public
+          def changeset(*)
+            raise NotImplementedError, "Changeset doesn't support combined relations yet"
+          end
         end
       end
     end

changeset/spec/integration/changeset_spec.rb

@@ -125,7 +125,7 @@ class User < Dry::Struct
         private
 
         def extend_tuple(tuple)
-          tuple.merge(title: tuple[:title] + ", yes really")
+          tuple.merge(title: "#{tuple[:title]}, yes really")
         end
       end
 
@@ -197,7 +197,7 @@ def extend_tuple(tuple)
         private
 
         def extend_tuple(tuple)
-          tuple.merge(title: tuple[:title] + ', yes really')
+          tuple.merge(title: "#{tuple[:title]}, yes really")
         end
       end
 

changeset/spec/shared/database.rb

@@ -21,8 +21,10 @@
   include_context 'database setup'
 
   before do
-    %i[tags tasks books posts_labels posts users labels
-     reactions messages].each { |table| conn.drop_table?(table) }
+    %i[
+      tags tasks books posts_labels posts users labels
+      reactions messages
+    ].each { |table| conn.drop_table?(table) }
 
     conn.create_table :users do
       primary_key :id

changeset/spec/shared/seeds.rb

@@ -10,8 +10,12 @@
 
     conn[:tags].insert task_id: task_id, name: 'red'
 
-    jane_post_id = conn[:posts].insert author_id: jane_id, title: 'Hello From Jane', body: 'Jane Post'
-    joe_post_id = conn[:posts].insert author_id: joe_id, title: 'Hello From Joe', body: 'Joe Post'
+    jane_post_id = conn[:posts].insert(
+      author_id: jane_id,
+      title: 'Hello From Jane',
+      body: 'Jane Post'
+    )
+    joe_post_id = conn[:posts].insert(author_id: joe_id, title: 'Hello From Joe', body: 'Joe Post')
 
     red_id = conn[:labels].insert name: 'red'
     green_id = conn[:labels].insert name: 'green'

changeset/spec/spec_helper.rb

@@ -34,9 +34,15 @@
 Dry::Core::Deprecations.set_logger!(SPEC_ROOT.join('../log/deprecations.log'))
 
 # Make inference errors quiet
-class ROM::SQL::Schema::Inferrer
-  def self.on_error(*args)
-    # shush
+module ROM
+  module SQL
+    module Schema
+      class Inferrer
+        def self.on_error(*args)
+          # shush
+        end
+      end
+    end
   end
 end
 

changeset/spec/unit/changeset_spec.rb

@@ -72,7 +72,9 @@
     it 'uses piped data for diff' do
       expect(relation).to receive(:one).and_return(jane)
 
-      changeset = ROM::Changeset::Update.new(relation).data(name: 'Jane').map { |t| { name: t[:name].upcase } }
+      changeset = ROM::Changeset::Update.new(relation).data(name: 'Jane').map do |t|
+        { name: t[:name].upcase }
+      end
 
       expect(changeset).to be_diff
     end

changeset/spec/unit/map_spec.rb

@@ -23,8 +23,12 @@ def default_command_type
       end
 
       it 'sets up custom data pipe' do
-        expect(changeset.to_h)
-          .to eql(name: 'Jane', address_street: 'Street 1', address_city: 'NYC', address_country: 'US')
+        expect(changeset.to_h).to eql(
+          name: 'Jane',
+          address_street: 'Street 1',
+          address_city: 'NYC',
+          address_country: 'US'
+        )
       end
     end
 
@@ -35,11 +39,11 @@ def default_command_type
       end
 
       it 'sets up custom data pipe' do
-        expect(changeset.to_a)
-          .to eql([
-            { name: 'Jane', address_street: 'Street 1', address_city: 'NYC', address_country: 'US' },
-            { name: 'Joe', address_street: 'Street 2', address_city: 'KRK', address_country: 'PL' }
-          ])
+        expect(changeset.to_a).to eql([
+          { name: 'Jane', address_street: 'Street 1', address_city: 'NYC',
+            address_country: 'US' },
+          { name: 'Joe', address_street: 'Street 2', address_city: 'KRK', address_country: 'PL' }
+        ])
       end
     end
   end

core/Gemfile

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-eval_gemfile '../Gemfile'
+eval_gemfile '../Gemfile'

core/Guardfile

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 group :red_green_refactor, halt_on_fail: true do
-  guard :rspec, cmd: "rspec", all_on_start: true do
+  guard :rspec, cmd: 'rspec', all_on_start: true do
     # run all specs if Gemfile.lock is modified
     watch('Gemfile.lock') { 'spec' }
 

core/Rakefile

@@ -14,11 +14,10 @@ task :"spec:isolation" do
   end
 end
 
+desc 'Run CI tasks'
 if RUBY_ENGINE != 'ruby'
-  desc 'Run CI tasks'
   task ci: %i[spec lint]
 else
-  desc 'Run CI tasks'
   task ci: %i[spec lint spec:isolation]
 end
 

core/benchmarks/setup.rb

@@ -92,7 +92,14 @@ def verify(&block)
   end
 end
 
-DATABASE_URL = ENV.fetch('DATABASE_URL', RUBY_ENGINE == 'jruby' ? 'jdbc:postgresql://localhost/rom' : 'postgres://localhost/rom')
+DATABASE_URL = ENV.fetch(
+  'DATABASE_URL',
+  if RUBY_ENGINE == 'jruby'
+    'jdbc:postgresql://localhost/rom'
+  else
+    'postgres://localhost/rom'
+  end
+)
 
 setup = ROM::Configuration.new(:sql, DATABASE_URL)
 
@@ -244,7 +251,7 @@ class Tags < ROM::Relation[:sql]
 
 ROM_ENV = ROM.container(setup)
 
-VERIFY = ENV.fetch('VERIFY') { false }
+VERIFY = ENV.fetch('VERIFY', false)
 COUNT = ENV.fetch('COUNT', 1000).to_i
 
 USER_SEED = COUNT.times.map { |i|

core/lib/rom/core.rb

@@ -28,7 +28,6 @@
 require 'rom/create_container'
 
 # register known plugin types
-require 'rom/schema_plugin'
 
 ROM::Plugins.register(:command)
 ROM::Plugins.register(:mapper)

core/lib/rom/lint/test.rb

@@ -14,11 +14,9 @@ module Test
       # @api private
       def define_test_method(name, &block)
         define_method "test_#{name}" do
-          begin
-            instance_eval(&block)
-          rescue ROM::Lint::Linter::Failure => f
-            raise Minitest::Assertion, f.message
-          end
+          instance_eval(&block)
+        rescue ROM::Lint::Linter::Failure => e
+          raise Minitest::Assertion, e.message
         end
       end
     end

core/lib/rom/plugins/command/timestamps.rb

@@ -24,6 +24,7 @@ module Command
       # @api public
       class Timestamps < Module
         attr_reader :timestamps, :datestamps
+
         def initialize(timestamps: [], datestamps: [])
           @timestamps = store_attributes(timestamps)
           @datestamps = store_attributes(datestamps)
@@ -117,7 +118,7 @@ module ClassInterface
           def timestamps(*names)
             timestamp_columns timestamp_columns.merge(names)
           end
-          alias timestamp timestamps
+          alias_method :timestamp, :timestamps
 
           # Set up attributes to datestamp when the command is called
           #
@@ -139,7 +140,7 @@ def timestamps(*names)
           def datestamps(*names)
             datestamp_columns datestamp_columns.merge(names)
           end
-          alias datestamp datestamps
+          alias_method :datestamp, :datestamps
         end
       end
     end

core/lib/rom/relation/class_interface.rb

@@ -188,7 +188,7 @@ def relation_name
       #
       # @api public
       def view(*args, &block)
-        if args.size == 1 && block.arity > 0
+        if args.size == 1 && block.arity.positive?
           raise ArgumentError, 'schema attribute names must be provided as the second argument'
         end
 
@@ -206,7 +206,7 @@ def view(*args, &block)
             new_schema_fn
           end
 
-        if relation_block.arity > 0
+        if relation_block.arity.positive?
           auto_curry_guard do
             define_method(name, &relation_block)
 

core/lib/rom/struct.rb

@@ -106,8 +106,8 @@ def respond_to_missing?(*)
 
     def method_missing(*)
       super
-    rescue NameError => error
-      raise MissingAttribute.new { "#{error.message} (attribute not loaded?)" }
+    rescue NameError => e
+      raise(MissingAttribute.new { "#{e.message} (attribute not loaded?)" })
     end
   end
 end

core/lib/rom/support/configurable.rb

@@ -7,7 +7,7 @@ module ROM
   # @api private
   module Configurable
     class Config
-      WRITER_REGEXP = /=$/.freeze
+      WRITER_REGEXP = /=$/
 
       # @!attribute [r] settings
       #   @return [Hash] A hash with defined settings

core/lib/rom/types.rb

@@ -8,7 +8,6 @@ module ROM
   #
   # @api public
   #
-  # rubocop:disable Naming/MethodName
   module Types
     include Dry::Types(default: :nominal)
 
@@ -44,11 +43,9 @@ def ForeignKey(relation, type = Types::Integer)
     # @api public
     def Coercible.JSONHash(symbol_keys: false, type: Types::Hash)
       Types.Constructor(type) do |value|
-        begin
-          ::JSON.parse(value.to_s, symbolize_names: symbol_keys)
-        rescue ::JSON::ParserError
-          value
-        end
+        ::JSON.parse(value.to_s, symbolize_names: symbol_keys)
+      rescue ::JSON::ParserError
+        value
       end
     end
 

repository/benchmarks/setup.rb

@@ -22,8 +22,8 @@ def benchmark(title)
     x.config(suite: GCSuite.new)
     def x.verify(*); end
 
-    def x.prepare(*) 
-      yield 
+    def x.prepare(*)
+      yield
     end
     yield x
     x.compare!