Fixes the issue where it was not possible to perform a touch through the TouchThroughView

.gitignore

@@ -24,4 +24,5 @@ project.xcworkspace
 *.iml
 .gradle
 local.properties
-android/build
+android/build
+**/.DS_Store

README.md

@@ -42,8 +42,43 @@ eg.
 
 Have a look at the demo in the example directory if you need more help.
 
-## Issues
-Currently we are working through an issue at #8 with Android devices on that latest version of React Native not properly passing through touch events. 
+## Android Installation
+For Android you have to do the normal react-native link. Also you have to change MainActivity inside you project. See example below
+
+```java
+package com.reactnativetouchthroughviewexample;
+
+import com.facebook.react.ReactActivity;
+import android.view.MotionEvent;
+import com.rome2rio.android.reactnativetouchthroughview.TouchThroughTouchHandlerInterface; 
+import com.rome2rio.android.reactnativetouchthroughview.TouchThroughTouchHandler; 
+
+public class MainActivity extends ReactActivity implements TouchThroughTouchHandlerInterface { 
+
+    private TouchThroughTouchHandler touchThroughTouchHandler = new TouchThroughTouchHandler();
+
+    /**
+     * Returns the name of the main component registered from JavaScript.
+     * This is used to schedule rendering of the component.
+     */
+    @Override
+    protected String getMainComponentName() {
+        return "reactnativetouchthroughviewexample";
+    }
+
+    public TouchThroughTouchHandler getTouchThroughTouchHandler() {
+        return touchThroughTouchHandler;
+    }
+
+    @Override
+    public boolean dispatchTouchEvent(MotionEvent ev) {
+        touchThroughTouchHandler.handleTouchEvent(ev);
+
+        return super.dispatchTouchEvent(ev);
+    }
+}
+
+```
 
 ## Credits
 Brought to you by the team at [Rome2rio](https://www.rome2rio.com). Find out how to join our team at <https://www.rome2rio.com/careers/>

RNTouchThroughView.podspec

@@ -0,0 +1,16 @@
+require 'json'
+package = JSON.parse(File.read('package.json'))
+
+Pod::Spec.new do |s|
+  s.name             = "RNTouchThroughView"
+  s.version          = package["version"]
+  s.summary          = package["description"]
+  s.requires_arc     = true
+  s.license          = package["license"]
+  s.homepage         = 'n/a'
+  s.authors          = { package["author"] => package["repository"]["url"] }
+  s.source           = { :git => package["repository"]["url"] }
+  s.source_files     = ['ios/*.{h,m}']
+  s.platform         = :ios, "8.0"
+  s.dependency          'React'
+end

android/build.gradle

@@ -1,9 +1,13 @@
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
 apply plugin: 'com.android.library'
 
+def DEFAULT_COMPILE_SDK_VERSION = 23
+def DEFAULT_BUILD_TOOLS_VERSION = "23.0.3"
+def DEFAULT_TARGET_SDK_VERSION  = 23
 
 buildscript {
     repositories {
+        google()
         jcenter()
     }
     dependencies {
@@ -16,6 +20,7 @@ buildscript {
 
 allprojects {
     repositories {
+        google()
         mavenLocal()
         jcenter()
         maven {
@@ -29,12 +34,12 @@ allprojects {
 
 
 android {
-  compileSdkVersion 23
-  buildToolsVersion "23.0.3"
+  compileSdkVersion project.hasProperty('compileSdkVersion') ? project.compileSdkVersion : DEFAULT_COMPILE_SDK_VERSION
+  buildToolsVersion project.hasProperty('buildToolsVersion') ? project.buildToolsVersion : DEFAULT_BUILD_TOOLS_VERSION
 
   defaultConfig {
     minSdkVersion 16
-    targetSdkVersion 23
+    targetSdkVersion project.hasProperty('targetSdkVersion') ? project.targetSdkVersion : DEFAULT_TARGET_SDK_VERSION
   }
 
   lintOptions {

android/gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-2.0-bin.zip
+distributionUrl=https://services.gradle.org/distributions/gradle-2.10-all.zip

android/src/main/java/com/rome2rio/android/reactnativetouchthroughview/TouchThroughTouchHandler.java

@@ -0,0 +1,25 @@
+package com.rome2rio.android.reactnativetouchthroughview;
+
+import android.view.MotionEvent;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class TouchThroughTouchHandler {
+
+    private List<TouchThroughTouchHandlerListener> listeners = new ArrayList();
+
+    public void addListener(TouchThroughTouchHandlerListener listener) {
+        listeners.add(listener);
+    }
+
+    public void removeListener(TouchThroughTouchHandlerListener listener) {
+        listeners.remove(listener);
+    }
+
+    public void handleTouchEvent(MotionEvent ev) {
+        for (TouchThroughTouchHandlerListener listener : listeners) {
+            listener.handleTouch(ev);
+        }
+    }
+}

android/src/main/java/com/rome2rio/android/reactnativetouchthroughview/TouchThroughTouchHandlerInterface.java

@@ -0,0 +1,7 @@
+package com.rome2rio.android.reactnativetouchthroughview;
+
+import android.view.MotionEvent;
+
+public interface TouchThroughTouchHandlerInterface {
+    public TouchThroughTouchHandler getTouchThroughTouchHandler();
+}

android/src/main/java/com/rome2rio/android/reactnativetouchthroughview/TouchThroughTouchHandlerListener.java

@@ -0,0 +1,7 @@
+package com.rome2rio.android.reactnativetouchthroughview;
+
+import android.view.MotionEvent;
+
+public abstract class TouchThroughTouchHandlerListener {
+    abstract void handleTouch(MotionEvent ev);
+}

android/src/main/java/com/rome2rio/android/reactnativetouchthroughview/TouchThroughViewManager.java

@@ -1,10 +1,10 @@
 package com.rome2rio.android.reactnativetouchthroughview;
 
-import com.facebook.react.uimanager.SimpleViewManager;
 import com.facebook.react.uimanager.ThemedReactContext;
+import com.facebook.react.uimanager.ViewGroupManager;
 
 public class TouchThroughViewManager
-        extends SimpleViewManager<TouchThroughView> {
+        extends ViewGroupManager<TouchThroughView> {
 
     public static final String REACT_CLASS = "R2RTouchThroughView";
 

android/src/main/java/com/rome2rio/android/reactnativetouchthroughview/TouchThroughViewPackage.java

@@ -24,7 +24,6 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
         return Collections.emptyList();
     }
 
-    @Override
     public List<Class<? extends JavaScriptModule>> createJSModules() {
         return Collections.emptyList();
     }

android/src/main/java/com/rome2rio/android/reactnativetouchthroughview/TouchThroughWrapper.java

@@ -1,49 +1,94 @@
 package com.rome2rio.android.reactnativetouchthroughview;
 
 import com.facebook.react.views.view.ReactViewGroup;
+import com.facebook.react.touch.ReactHitSlopView;
+import com.facebook.react.bridge.ReactContext;
 
+import android.app.Activity;
 import android.content.Context;
+import android.util.Log;
 import android.view.MotionEvent;
 import android.view.View;
 import android.graphics.Rect;
 import android.view.ViewGroup;
 
-public class TouchThroughWrapper extends ReactViewGroup {
-    public TouchThroughWrapper(Context context) {
+public class TouchThroughWrapper extends ReactViewGroup implements ReactHitSlopView {
+    private boolean lastTouchWasNotValid = false;
+    private final ViewGroup viewGroup = this;
+    private TouchThroughTouchHandler handler;
+
+    public TouchThroughWrapper(ReactContext context) {
         super(context);
+        if (context == null) {
+            return;
+        }
+        Activity activity = context.getCurrentActivity();
+        if (activity == null) {
+            return;
+        }
+        if (activity instanceof TouchThroughTouchHandlerInterface) {
+            TouchThroughTouchHandlerInterface handlerInterface = (TouchThroughTouchHandlerInterface) activity;
+            handler = handlerInterface.getTouchThroughTouchHandler();
+        } else {
+            throw new RuntimeException("TouchThroughTouchHandlerInterface was not set on app activity");
+        }
     }
 
     @Override
     public boolean onInterceptTouchEvent(MotionEvent event) {
-        // Recursively find out if an absolute x/y position is hitting a child view and stop event
-        // propagation if a hit is found.
-        return this.isTouchingTouchThroughView(this, Math.round(event.getX()), Math.round(event.getY()));
+        return lastTouchWasNotValid;
+    }
+
+    private TouchThroughTouchHandlerListener listener = new TouchThroughTouchHandlerListener() {
+        @Override
+        void handleTouch(MotionEvent ev) {
+            if (ev.getAction() == MotionEvent.ACTION_DOWN) {
+                lastTouchWasNotValid = isTouchingTouchThroughView(viewGroup, (int) ev.getX(), (int) ev.getY());
+            }
+        }
+    };
+    public void addActivityListener() {
+        if(handler != null) {
+            handler.addListener(listener);
+        }
     }
 
+    public void removeActivityListener() {
+        if(handler != null) {
+            handler.removeListener(listener);
+        }
+    }
+
+    // Recursively find out if an absolute x/y position is hitting a child view and stop event
+    // propagation if a hit is found.
     private boolean isTouchingTouchThroughView(ViewGroup viewgroup, int x, int y) {
         boolean isTouchingTouchThroughView = false;
 
-        for(int i = 0; i < viewgroup.getChildCount(); i++) {
+        for (int i = 0; i < viewgroup.getChildCount(); i++) {
             View child = viewgroup.getChildAt(i);
 
             boolean isViewGroup = child instanceof ViewGroup;
             boolean isTouchThroughView = child instanceof TouchThroughView;
 
             if (isTouchThroughView) {
+                Rect bounds = new Rect();
+                isTouchingTouchThroughView = child.getGlobalVisibleRect(bounds) && bounds.contains(x, y);
+                /*
                 int[] location = new int[2];
                 int[] thisLocation = new int[2];
 
-                child.getLocationOnScreen(location);
+
+                //child.getLocationOnScreen(location);
                 this.getLocationOnScreen(thisLocation);
 
                 int childX = location[0] - thisLocation[0];
                 int childY = location[1] - thisLocation[1];
 
-                Rect bounds = new Rect(childX, childY, childX + child.getWidth(), childY + child.getHeight());
+                //Rect bounds = new Rect(childX, childY, childX + child.getWidth(), childY + child.getHeight());
 
                 isTouchingTouchThroughView = bounds.contains(x, y);
-            }
-            else if (isViewGroup) {
+                */
+            } else if (isViewGroup) {
                 isTouchingTouchThroughView = this.isTouchingTouchThroughView((ViewGroup) child, x, y);
             }
 
@@ -60,4 +105,12 @@ public boolean onTouchEvent(MotionEvent event) {
         // Pass through touch events to layer behind.
         return false;
     }
-}
+
+    //If the touch was not on the list make the slop rect small so react-native dont use this view as responder
+    public Rect getHitSlopRect() {
+        if (lastTouchWasNotValid) {
+            return new Rect(-1000, -1000, -1000, -1000);
+        }
+        return new Rect(0, 0, 0, 0);
+    }
+}

android/src/main/java/com/rome2rio/android/reactnativetouchthroughview/TouchThroughWrapperManager.java

@@ -13,8 +13,16 @@ public class TouchThroughWrapperManager
     public String getName() {
         return REACT_CLASS;
     }
+
     @Override
     public TouchThroughWrapper createViewInstance(ThemedReactContext context) {
-      return new TouchThroughWrapper(context);
+        TouchThroughWrapper view = new TouchThroughWrapper(context);
+        view.addActivityListener();
+        return view;
+    }
+
+    @Override
+    public void onDropViewInstance(TouchThroughWrapper view) {
+        view.removeActivityListener();
     }
 }

example-react-native-navigation/README.md

@@ -0,0 +1,28 @@
+# Example for react-native-navigation
+
+This example is copied from https://github.com/wix/react-native-navigation/tree/master/example
+
+It shows how to implement react-native-navigation for android
+
+## Javascript
+
+An example for the javascript part is under the "Push" section and in the file: src/screens/types/Push.js
+
+## Android
+
+### Implementation Details
+
+Use TouchThroughActivity from `android/app/src/main/java/com/example/TouchThroughActivity.java` as implementation for the `TouchThroughTouchHandlerInterface` interface
+
+Add `<activity android:name=".TouchThroughActivity" />` to `AndroidManifest.xml`
+
+Override `startActivity` in NavigationApplication
+
+```java
+@Override
+public void startActivity(Intent intent) {
+    intent.setClass(NavigationApplication.instance, TouchThroughActivity.class);
+
+    super.startActivity(intent);
+}
+```

example-react-native-navigation/android/.project

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>example</name>
+	<comment>Project example created by Buildship.</comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.buildship.core.gradleprojectbuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
+	</natures>
+</projectDescription>

example-react-native-navigation/android/.settings/org.eclipse.buildship.core.prefs

@@ -0,0 +1,2 @@
+#Thu Apr 05 19:51:51 CEST 2018
+connection.project.dir=

example-react-native-navigation/android/app/.classpath

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8/"/>
+	<classpathentry kind="con" path="org.eclipse.buildship.core.gradleclasspathcontainer"/>
+	<classpathentry kind="output" path="bin"/>
+</classpath>

example-react-native-navigation/android/app/.project

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>app</name>
+	<comment>Project app created by Buildship.</comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.jdt.core.javabuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.buildship.core.gradleprojectbuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.jdt.core.javanature</nature>
+		<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
+	</natures>
+</projectDescription>