Encoding::Base16.decode should actually return an ASCII-8bit String.

ronin-rb · Jun 9, 2023 · c0f29f9 · c0f29f9
1 parent f3cc768
commit c0f29f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/ronin/support/encoding/base16.rb b/lib/ronin/support/encoding/base16.rb
@@ -71,7 +71,7 @@ def self.encode(data)
         #   # => "hello"
         #
         def self.decode(data)
-          decoded = String.new(encoding: Encoding::UTF_8)
+          decoded = String.new(encoding: Encoding::ASCII_8BIT)
 
           data.scan(/../).each do |hex_char|
             decoded << hex_char.to_i(16).chr

diff --git a/spec/encoding/base16_spec.rb b/spec/encoding/base16_spec.rb
@@ -17,8 +17,8 @@
       expect(subject.decode(data)).to eq("hello\x4e")
     end
 
-    it "must set the String encoding to Encoding::UTF_8" do
-      expect(subject.decode(data).encoding).to be(Encoding::UTF_8)
+    it "must set the String encoding to Encoding::ASCII_8BIT" do
+      expect(subject.decode(data).encoding).to be(Encoding::ASCII_8BIT)
     end
   end
 end