Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a URI::HTTP#vulns/has_vulns? core-ext methods #89

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add a URI::HTTP#vulns/has_vulns? core-ext methods #89

merged 1 commit into from
Aug 28, 2024

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Aug 25, 2024

No description provided.

@moozzi moozzi linked an issue Aug 25, 2024 that may be closed by this pull request
Add a URI::HTTP#vulns and #has_vulns? core-ext methods #85
Closed
@moozzi moozzi self-assigned this Aug 25, 2024
@moozzi moozzi requested a review from postmodern August 25, 2024 17:18
postmodern
postmodern requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor documentation improvements. Might also want to copy/paste the examples to the README as well.

lib/ronin/vulns/core_ext/uri/http.rb Show resolved Hide resolved
lib/ronin/vulns/core_ext/uri/http.rb Outdated Show resolved Hide resolved
lib/ronin/vulns/core_ext/uri/http.rb Show resolved Hide resolved
postmodern
postmodern requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to require vulns/core_ext to the lib/ronin/vulns.rb file so that it's required by default. Might also need to add ronin/vulns/core_ext.rb and ronin/vulns/core_ext/uri.rb files.

@postmodern
Copy link
Member

@AI-Mozi I also created a 0.3.0 branch for any new features/code. Should rebase against 0.3.0.

@moozzi moozzi force-pushed the add_uri_http_vulns_has_vulns_core_ext_methods branch 2 times, most recently from cb97dd2 to 7b027cb Compare August 26, 2024 06:55
@moozzi moozzi changed the base branch from main to 0.3.0 August 26, 2024 06:56
moozzi
moozzi commented Aug 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@moozzi moozzi force-pushed the add_uri_http_vulns_has_vulns_core_ext_methods branch from 7b027cb to 0f2f68f Compare August 28, 2024 15:02
@postmodern postmodern merged commit 68deebd into ronin-rb:0.3.0 Aug 28, 2024
6 checks passed
@postmodern postmodern mentioned this pull request Aug 28, 2024
Closed
@postmodern postmodern added the feature New Feature label Aug 28, 2024
@postmodern postmodern added this to the 0.3.0 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern approved these changes

Assignees

@moozzi moozzi

Labels
feature New Feature
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Add a URI::HTTP#vulns and #has_vulns? core-ext methods
2 participants
@moozzi @postmodern