Skip to content

Commit

Permalink
update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ThierryO committed Jan 20, 2021
1 parent 8ef724c commit 827848a
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 8 deletions.
35 changes: 28 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
## Test environments
* local
* ubuntu 18.04.3 LTS, R 3.6.1
* travis-ci
* trusty, oldrel
* xenial, release and devel
* osx, release
* AppVeyor
* Windows Server 2012 R2 x64, R 3.6.1 Patched
* ubuntu 18.04.5 LTS, R 4.0.3
* github actions
* macOS-latest, release
* windows-latest, release
* ubuntu 20.04, devel
* ubuntu 16.04, oldrel
* checklist package: ubuntu 20.04.1, R 4.0.3
* r-hub
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
* Ubuntu Linux 16.04 LTS, R-release, GCC
Expand All @@ -15,3 +15,24 @@
## R CMD check results

0 errors | 0 warnings | 0 note

r-hub gave a few false positive notes

* Windows Server 2008 R2 SP1, R-devel, 32/64 bit

```
Possibly mis-spelled words in DESCRIPTION:
rdata (28:22, 31:33, 36:20, 40:48, 41:20, 43:24, 44:62, 45:62)
workflow (41:37, 44:15, 44:36)
```

* Fedora Linux, R-devel, clang, gfortran

```
Possibly mis-spelled words in DESCRIPTION:
rdata (28:22, 31:33, 36:20, 40:48, 41:20, 43:24, 44:62, 45:62)
```

Ubuntu Linux 16.04 LTS, R-release, GCC failed on r-hub because ICU is not
available on that build.

2 changes: 1 addition & 1 deletion vignettes/split_by.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ We add an `index.tsv` containing the combinations of the `split_by` variables an
This hash becomes the base name of the partial data files.

Splitting the dataframe into smaller files makes them easier to handle in version control system.
The overall size depends on the amount of replication in the dataframe.
The total size depends on the amount of replication in the dataframe.
More on that in the next section.

## When to Split the Dataframe
Expand Down

0 comments on commit 827848a

Please sign in to comment.