always use encoding with readLines()

ropensci · Oct 24, 2019 · bcc2f61 · bcc2f61
1 parent c4a1913
commit bcc2f61
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/tests/testthat/test_a_basics.R b/tests/testthat/test_a_basics.R
@@ -255,7 +255,7 @@ test_that("user specified na strings work", {
   )
   git2rdata:::set_local_locale(old_locale)
   expect_identical(
-    grep("junk", readLines(file.path(root, fn[1]))),
+    grep("junk", readLines(file.path(root, fn[1]), encoding = "UTF-8")),
     2:4
   )
   expect_error(
@@ -279,7 +279,7 @@ test_that("user specified na strings work", {
   )
   git2rdata:::set_local_locale(old_locale)
   expect_identical(
-    grep("junk", readLines(file.path(root, fn[1]))),
+    grep("junk", readLines(file.path(root, fn[1]), encoding = "UTF-8")),
     2:4
   )
   file.remove(list.files(root, recursive = TRUE, full.names = TRUE))

diff --git a/tests/testthat/test_b_is_git2rmeta.R b/tests/testthat/test_b_is_git2rmeta.R
@@ -122,7 +122,7 @@ test_that("is_git2rdata checks data", {
   junk <- write_vc(test_data, file = file, root = root, sorting = "test_Date")
   correct_yaml <- yaml::read_yaml(file.path(root, junk[2]))
   yaml::write_yaml(correct_yaml, file.path(root, junk[2]))
-  correct_data <- readLines(file.path(root, junk[1]))
+  correct_data <- readLines(file.path(root, junk[1]), encoding = "UTF-8")
   junk_header <- correct_data
   junk_header[1] <- "junk"
   writeLines(junk_header, file.path(root, junk[1]))

diff --git a/tests/testthat/test_e_validate_metadata.R b/tests/testthat/test_e_validate_metadata.R
@@ -35,7 +35,7 @@ test_that("read_vc() checks hash", {
 test_that("read_vc() handles changes in rawdata", {
   file <- basename(tempfile(tmpdir = root))
   junk <- write_vc(test_data, file = file, root = root, sorting = "test_Date")
-  correct_data <- readLines(file.path(root, junk[1]))
+  correct_data <- readLines(file.path(root, junk[1]), encoding = "UTF-8")
   correct_header <- strsplit(correct_data[1], "\t")[[1]]
   junk_data <- correct_data
   junk_data[1] <- paste(correct_header[-1], collapse = "\t")