Code

Fix problem on data hashes (#49)#53

Code

Merged

ThierryO merged 47 commits intomasterropensci/git2rdata:masterfrom datahashropensci/git2rdata:datahashCopy head branch name to clipboardNov 8, 2019

+365-159

Commits

Commits on Oct 24, 2019

• remove superfluous imported function

  

  ElsLommelen

  authored and

  ThierryO

  committed
  bdded82

  Copy full SHA for bdded82

• write function datahash to calculate hash of dataframe

  

  ElsLommelen

  authored and

  ThierryO

  committed
  a1eb8bd

  Copy full SHA for a1eb8bd

• calculate data_hash with datahash instead of hashfile

  

  ElsLommelen

  authored and

  ThierryO

  committed
  356b336

  Copy full SHA for 356b336

• rewrite documentation of is_git2rdata

  

  ElsLommelen

  authored and

  ThierryO

  committed
  bb0e2cd

  Copy full SHA for bb0e2cd

• remove unittest of is_git2rdata on data hash

  

  ElsLommelen

  authored and

  ThierryO

  committed
  0d2bee2

  Copy full SHA for 0d2bee2

• correction

  

  ElsLommelen

  authored and

  ThierryO

  committed
  85ea2fd

  Copy full SHA for 85ea2fd

• add special characters to test_data

  

  ElsLommelen

  authored and

  ThierryO

  committed
  6a33d9e

  Copy full SHA for 6a33d9e

• test equality of hash in different OS

  

  ElsLommelen

  authored and

  ThierryO

  committed
  a52e4e3

  Copy full SHA for a52e4e3

• correct error in attribute hashes of output read_vc

  

  ElsLommelen

  authored and

  ThierryO

  committed
  b0b1851

  Copy full SHA for b0b1851

• test to replace deleted unittest

  

  ElsLommelen

  authored and

  ThierryO

  committed
  66d4ef9

  Copy full SHA for 66d4ef9

• simplify function datahash

  

  ElsLommelen

  authored and

  ThierryO

  committed
  20119c8

  Copy full SHA for 20119c8

• change data hash in read_vc if data have altered outside of git2rdata

  

  ElsLommelen

  authored and

  ThierryO

  committed
  aa2e1a2

  Copy full SHA for aa2e1a2

• change problem chars to unicode notation

  

  ElsLommelen

  authored and

  ThierryO

  committed
  6e42072

  Copy full SHA for 6e42072

• change data hash value limits the problem to first read in windows

  

  ElsLommelen

  authored and

  ThierryO

  committed
  733f36f

  Copy full SHA for 733f36f

• only convert characters in read_vc (not in write_vc

  

  ElsLommelen

  authored and

  ThierryO

  committed
  3ad1b29

  Copy full SHA for 3ad1b29

• typo

  

  ElsLommelen

  authored and

  ThierryO

  committed
  5b33bdf

  Copy full SHA for 5b33bdf

• add € to test

  

  ElsLommelen

  authored and

  ThierryO

  committed
  33276ad

  Copy full SHA for 33276ad

• Update R/datahash.R

  Show description for 49c28b2
  

  ElsLommelen

  and

  ThierryO

  committed
  49c28b2

  Copy full SHA for 49c28b2

• Update R/datahash.R

  Show description for 8e4ee17
  

  ElsLommelen

  and

  ThierryO

  committed
  8e4ee17

  Copy full SHA for 8e4ee17

• Update R/datahash.R

  Show description for 34ea931
  

  ElsLommelen

  and

  ThierryO

  committed
  34ea931

  Copy full SHA for 34ea931

• Update R/datahash.R

  Show description for f2ace52
  

  ElsLommelen

  and

  ThierryO

  committed
  f2ace52

  Copy full SHA for f2ace52

• update description and news files

  

  ElsLommelen

  authored and

  ThierryO

  committed
  9394950

  Copy full SHA for 9394950

• update the minimal package version in is_git2rmeta()

  ThierryO

  committed
  d1f4fd5

  Copy full SHA for d1f4fd5

• upgrade_data() updates the data hash in data written with version 0.0.5 to 0.1.0.9000

  ThierryO

  committed
  85937c8

  Copy full SHA for 85937c8

• update documentation

  ThierryO

  committed
  9a2a447

  Copy full SHA for 9a2a447

• test for equal hashes with tabs or newlines in dataset

  

  ElsLommelen

  authored and

  ThierryO

  committed
  256c204

  Copy full SHA for 256c204

• use unchanged input data to calculate data hash in write_vc

  

  ElsLommelen

  authored and

  ThierryO

  committed
  d0b25e5

  Copy full SHA for d0b25e5

• try to fix datahash on linux

  ThierryO

  committed
  89ac8ef

  Copy full SHA for 89ac8ef

• always use "C" locale when sorting

  Show description for 51d8368
  ThierryO

  committed
  51d8368

  Copy full SHA for 51d8368

• ignore .httr-oauth file

  ThierryO

  committed
  38bcdad

  Copy full SHA for 38bcdad

• use iconv() to make sure that we use UTF-8 for all characters and factors

  ThierryO

  committed
  fa37c27

  Copy full SHA for fa37c27

• add from = "UTF-8" argument to iconv() calls

  ThierryO

  committed
  7ddd4f0

  Copy full SHA for 7ddd4f0

• fix linters

  ThierryO

  committed
  c4a1913

  Copy full SHA for c4a1913

• always use encoding with readLines()

  ThierryO

  committed
  bcc2f61

  Copy full SHA for bcc2f61

• use enc2utf8() instead of iconv()

  ThierryO

  committed
  cfd1c4b

  Copy full SHA for cfd1c4b

• add more unit tests to investigate the problem

  ThierryO

  committed
  9fcdf47

  Copy full SHA for 9fcdf47

• extra unit tests

  ThierryO

  committed
  dd6c256

  Copy full SHA for dd6c256

Commits on Oct 25, 2019

• calculate datahash as a hash of hashes

  ThierryO

  committed
  65012fc

  Copy full SHA for 65012fc

• trace problem

  ThierryO

  committed
  e607d14

  Copy full SHA for e607d14

• hash problem might be due to differences in factor levels

  Show description for 0afc131
  ThierryO

  committed
  0afc131

  Copy full SHA for 0afc131

• set locale to C in unit tests when creating factors

  ThierryO

  committed
  cd96e85

  Copy full SHA for cd96e85

Commits on Nov 7, 2019

• reduce cyclomatic complexity of read_vc()

  ThierryO

  committed
  be8f2e3

  Copy full SHA for be8f2e3

• ignore code coverage for datahash of very large files (> 1e8 lines)

  ThierryO

  committed
  d4bb2b0

  Copy full SHA for d4bb2b0

• reduce cyclomatic complexity in compare_meta()

  ThierryO

  committed
  84ad022

  Copy full SHA for 84ad022

• reordering factor levels requires strict = FALSE

  ThierryO

  committed
  cf2e53e

  Copy full SHA for cf2e53e

Commits on Nov 8, 2019

• update data in efficiency vignette

  ThierryO

  committed
  41cab26

  Copy full SHA for 41cab26

• add video of our talk at useR!2019

  ThierryO

  committed
  e02e802

  Copy full SHA for e02e802