Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to broken logo + shorten title to package title #54

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

peterdesmet
Copy link
Member

Description

  • Use relative link for logo: should work on GitHub and pkgdown website
  • Use git2rdata as title
  • Fix typo in alt

Related Issue

Example

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #54   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         696    696           
=====================================
  Hits          696    696

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f195be2...1f83714. Read the comment docs.

@ThierryO
Copy link
Member

Thanks for the notification. The fix still needs an absolute URL since the README is also displayed at other locations where the relative URL won't work. Can you update the PR?

@peterdesmet
Copy link
Member Author

Well, for the location you mention it seems the relative link also works though: https://cran.rstudio.com/web/packages/bioRad/readme/README.html

I've basically taken the approach from pkgdown itself: https://github.com/r-lib/pkgdown/blob/d01672efa3baa80fd7ab238b7143080b0daf49a4/README.Rmd#L15

@ThierryO ThierryO merged commit 4c49807 into master Oct 22, 2019
@ThierryO ThierryO deleted the peterdesmet-patch-1 branch October 22, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants