Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller changes in the split_by vignette #63

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Conversation

florisvdh
Copy link
Collaborator

This PR suggests some smaller changes in the split_by vignette, i.e. relating to #62 .

For some reason, the package check fails. I did run codemetar::write_codemeta() as suggested by the codemeta error and pushed the resulting change, but it did not help.

Locally, the check succeeds with one note 'unable to verify current time'.

@florisvdh florisvdh requested a review from ThierryO September 23, 2020 13:00
Copy link
Member

@ThierryO ThierryO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions.

@ThierryO ThierryO merged commit 6b28a55 into split_table Sep 23, 2020
@ThierryO ThierryO deleted the split_by_fv branch September 23, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants