Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cob_common: 2.8.12-1 in 'jazzy/distribution.yaml' [bloom] #43653

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Deleh
Copy link

@Deleh Deleh commented Nov 25, 2024

Increasing version of package(s) in repository cob_common to 2.8.12-1:

cob_actions

  • No changes

cob_msgs

  • No changes

cob_srvs

  • No changes

@github-actions github-actions bot added the jazzy Issue/PR is for the ROS 2 Jazzy distribution label Nov 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

- cob_srvs
tags:
release: release/jazzy/{package}/{version}
url: https://github.com/4am-robotics/cob_common-release.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is allowed for jazzy, but please see #43654 (review) . It is usually a good idea to move this release repository to ros2-gbp, and then to use that release repository for everything.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@quarkytale
Copy link
Contributor

Hi @Deleh there are some tests failing due to

E               RuntimeError: jazzy: missing package.xml file for package "cob_actions"
E               jazzy: missing package.xml file for package "cob_msgs"
E               jazzy: missing package.xml file for package "cob_srvs"

Can you please update accordingly?

@clalancette clalancette added the changes requested Maintainers have asked for changes to the pull request label Dec 4, 2024
@Deleh
Copy link
Author

Deleh commented Dec 9, 2024

Hi @Deleh there are some tests failing due to

E               RuntimeError: jazzy: missing package.xml file for package "cob_actions"
E               jazzy: missing package.xml file for package "cob_msgs"
E               jazzy: missing package.xml file for package "cob_srvs"

Can you please update accordingly?

The test logs unfortunately look a bit cryptic to me as the files exist. But could it perhaps have something to do with the fact that the release repository doesn't exist yet?

@clalancette
Copy link
Contributor

The test logs unfortunately look a bit cryptic to me as the files exist. But could it perhaps have something to do with the fact that the release repository doesn't exist yet?

Yes, that is likely the case.

@Deleh
Copy link
Author

Deleh commented Dec 16, 2024

The release repository is now deployed:

@clalancette could you please re-run the failed test?

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Dec 31, 2024
@christian-rauch
Copy link
Contributor

@Deleh Are you able to trigger the failed workflow yourself? Alternatively, @clalancette can you trigger the workflow and review this again?

@Deleh Deleh requested a review from clalancette January 8, 2025 14:25
@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request jazzy Issue/PR is for the ROS 2 Jazzy distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants