Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ar4_ros_driver to Jazzy #43773

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Add ar4_ros_driver to Jazzy #43773

merged 2 commits into from
Jan 2, 2025

Conversation

ycheng517
Copy link
Contributor

@ycheng517 ycheng517 commented Dec 3, 2024

Please Add This Package to be indexed in the rosdistro.

jazzy

The source is here:

https://github.com/ycheng517/ar4_ros_driver

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the jazzy Issue/PR is for the ROS 2 Jazzy distribution label Dec 3, 2024
@ycheng517 ycheng517 changed the title Add ar4_ros_driver Add ar4_ros_driver to Jazzy Dec 3, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New package review checklist

jazzy/distribution.yaml Outdated Show resolved Hide resolved
@clalancette clalancette added the changes requested Maintainers have asked for changes to the pull request label Dec 4, 2024
Co-authored-by: Chris Lalancette <[email protected]>
@ycheng517 ycheng517 requested a review from clalancette December 4, 2024 19:33
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@clalancette
Copy link
Contributor

Besides fixing the CI, we also need to rename the packages (see #43773 (review)).

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Dec 19, 2024
@ycheng517
Copy link
Contributor Author

I am working on renaming the packages. Should be ready in a few days. Will request for re-review soon!

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Dec 20, 2024
@ycheng517
Copy link
Contributor Author

ycheng517 commented Dec 20, 2024

I've updated the package names in my repo to annin_ar4_{description,gazebo,hardware_interface,moveit_config}. Please re-review! @clalancette

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@clalancette clalancette merged commit d7ebfa6 into ros:master Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request jazzy Issue/PR is for the ROS 2 Jazzy distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants