ros2_planning_system: 2.0.18-1 in 'jazzy/distribution.yaml' [bloom]

[fmrico]

Increasing version of package(s) in repository ros2_planning_system to 2.0.18-1:

• upstream repository: https://github.com/PlanSys2/ros2_planning_system.git
• release repository: https://github.com/ros2-gbp/ros2_planning_system-release.git
• distro file: jazzy/distribution.yaml
• bloom version: 0.12.0
• previous version for package: 2.0.15-1

plansys2_bringup

• No changes

plansys2_bt_actions

• No changes

plansys2_core

• No changes

plansys2_domain_expert

• No changes

plansys2_executor

* Fix get plan services
* Contributors: Francisco Martín Rico

plansys2_lifecycle_manager

• No changes

plansys2_msgs

• No changes

plansys2_pddl_parser

• No changes

plansys2_planner

• No changes

plansys2_popf_plan_solver

• No changes

plansys2_problem_expert

• No changes

plansys2_support_py

• No changes

plansys2_terminal

• No changes

plansys2_tests

• No changes

plansys2_tools

• No changes

[fmrico]

Hi,

I am trying to solve this

08:12:29 -- Found plansys2_executor: 2.0.15 (/opt/ros/jazzy/share/plansys2_executor/cmake)
08:12:29 CMake Error at /opt/ros/jazzy/share/plansys2_executor/cmake/ament_cmake_export_dependencies-extras.cmake:21 (find_package):
08:12:29   By not providing "FindEigen3.cmake" in CMAKE_MODULE_PATH this project has
08:12:29   asked CMake to find a package configuration file provided by "Eigen3", but
08:12:29   CMake did not find one.
08:12:29 
08:12:29   Could not find a package configuration file provided by "Eigen3" with any
08:12:29   of the following names:
08:12:29 
08:12:29     Eigen3Config.cmake
08:12:29     eigen3-config.cmake
08:12:29 
08:12:29   Add the installation prefix of "Eigen3" to CMAKE_PREFIX_PATH or set
08:12:29   "Eigen3_DIR" to a directory containing one of the above files.  If "Eigen3"
08:12:29   provides a separate development package or SDK, be sure it has been
08:12:29   installed.
08:12:29 Call Stack (most recent call first):
08:12:29   /opt/ros/jazzy/share/plansys2_executor/cmake/plansys2_executorConfig.cmake:41 (include)
08:12:29   CMakeLists.txt:11 (find_package)
08:12:29 

I think I got it with:

<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
  <name>plansys2_executor</name>
  <version>2.0.17</version>
  
 ... 

  <buildtool_depend>eigen3_cmake_module</buildtool_depend>
  <build_depend>eigen</build_depend>

...
  <buildtool_export_depend>eigen3_cmake_module</buildtool_export_depend>
  <build_export_depend>eigen</build_export_depend>

...
</package>

and

cmake_minimum_required(VERSION 3.5)
project(plansys2_executor)

. . . 

find_package(eigen3_cmake_module REQUIRED)
find_package(Eigen3)
set(dependencies
    Eigen3
    eigen3_cmake_module
    ...
)
...
add_library(${PROJECT_NAME} SHARED ${EXECUTOR_SOURCES})
ament_target_dependencies(${PROJECT_NAME} ${dependencies})
target_link_libraries(${PROJECT_NAME})
...
ament_export_dependencies(${dependencies})

...

ament_package()

I hope this fixes the errors that are produced in the buildfarm.

Francisco

[github-actions]

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

• ROS Distributions are created using REP-134 Standards Track as a guide.
• Your package name should comply to REP-144 ROS Package Naming
• Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
• Your package must contain an OSI approved license. Your package.xml file must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details.
• A publicly available, open source, repository for your ROS package.
• While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
• If you would like, you may join our Discord Server and ask questions in the #infra-help channel.

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

• REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
• Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
• Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
• We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.

---

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks