Re-structured PPStrip, RGB global brightness, etc... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brightness, type-mismatch warnings • Re-structured PPStrip to convert RBG values of various types to a table of bytes as these values are presented, rather than when [PPStrip serialize] is called. After this, the code that presented the values (in uint8s) ran twice as fast, and [serialize] probably ran 100x as fast since all it does now is copy a block of bytes. • Fixed recent code written to handle 16-bit RGB components (not tested yet since we don't have the 16-bit hardware yet!) • Expanded the global brightness properties in various classes to handle separated brightness adjustments for red, green, and blue. • Fixed a few type-mismatch warnings, particularly ones where an unsigned int was compared to a signed int. Signed-off-by: schardt <[email protected]>
schardt
changed the title
…(and saved 200K in the build size). Simplified and sped up PPCard by taking out packetPool and packetPromiseDict.
… Removed use of custom macros, categories. Removed unused files (for clarity). Added a lot of comments.
…ing done. Added LOG() and ASSERT() macros. Removed alternate completion notification schemes from PPPusher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Re-structured PPStrip to convert RBG values of various types to a table of bytes as these values are presented, rather than when [PPStrip serialize] is called. After this, the code that presented the values (in uint8s) ran twice as fast, and [serialize] probably ran 100x as fast since all it does now is copy a block of bytes. (It's amazing to me just how much overhead manipulating an NSArray of PPPixel objects turned out to cause.)
• Fixed recent code written to handle 16-bit RGB components (not tested yet since we don't have the 16-bit hardware yet!)
• Expanded the global brightness properties in various classes to handle separated brightness adjustments for red, green, and blue.
• Fixed a few type-mismatch warnings, particularly ones where an unsigned int was compared to a signed int.
Signed-off-by: schardt [email protected]