Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launcher mounts #109

Merged
merged 8 commits into from
Dec 7, 2021
Merged

Fix launcher mounts #109

merged 8 commits into from
Dec 7, 2021

Conversation

colearendt
Copy link
Contributor

@colearendt colearendt commented Dec 7, 2021

  • Simple little change to add a whitespace line between array entries when generating a dcf file
  • Messy b/c we have to then update versions for every chart that uses the rstudio-library chart, update lockfile, update README, update NEWS, etc.
    • (Perhaps we should have a just target for simplifying this process at some point...? We will have to do it again for Check storage class #98 😞 )

Close #108

@colearendt colearendt requested a review from atheriel December 7, 2021 13:54
@colearendt colearendt merged commit 102827b into main Dec 7, 2021
@colearendt colearendt deleted the fix-launcher-mounts branch December 7, 2021 17:23
d-m pushed a commit to d-m/helm that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix parsing of launcher-mounts file
3 participants