Update licenses, add chart keyword and update descriptions #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexMapley
requested review from
aronatkins,
dbkegley,
christierney,
zackverham,
a team,
colearendt and
atheriel
as code owners
AlexMapley
force-pushed
the
rstudio_posit_partial_migration
branch
from
2bdde59 to
ed1fdee
Compare
shepherdjerred
approved these changes
Dec 5, 2023
aronatkins
approved these changes
Dec 8, 2023
kfeinauer
approved these changes
Dec 12, 2023
|
This PR is still completely valid and i'd like to merge. I don't think we should bump up the chart version for these changes, but we're going to continue to fail our |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
RStudio has rebranded to Posit, and over time we're migrating our code to reflect that.
This PR is a small step towards that migration for our helm charts, just updating some behind the scenes things.
Summary
positkeyword to all helm charts for better search-abilitycharts/rstudio-library/Chart.yamldescriptionNotes
We're failing a linting ci job because i haven't bumped up the chart versions, i'm going to ignore that for now. I don't intend to bump the chart versions with these changes