Adding more unit tests for the rstudio-workbench chart #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… limit key is set even when the resource limits are not disabled
GCRev
reviewed
Dec 4, 2024
Comment on lines
-186
to
+187
| limits: | ||
| {{- if .Values.resources.limits.enabled }} | ||
| limits: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found what I consider to be a bug:
helm/charts/rstudio-workbench/templates/_helpers.tpl
Lines 186 to 187 in a34cf7f
I've added that fix here, and all the existing unit tests continue to work so, huzzah! Tests doing their thing
Otherwise, added more tests to attempt to cover all of the branching in
rstudio-workbench.containersin_helpers.tpl