-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pwb 2024.12.0 #631
Merged
Merged
Bump pwb 2024.12.0 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
melissa-barca
commented
Dec 17, 2024
- bump pwb to 2024.12.0
- update vs code default config values to match those in workbench
- add positron config files commented out in case customers want to try it out while the feature is in preview
- pull in changes from Bump launcher templates for Workbench chart to 2.5.0 #629
Adds init containers support from the Job spec.
Workbench defaults, add commented out positron configuration
melissa-barca
force-pushed
the
bump-pwb-2024.12.0
branch
from
December 17, 2024 16:11
123fa4d
to
3f5b76f
Compare
zachhannum
reviewed
Dec 17, 2024
Co-authored-by: Zach Hannum <[email protected]>
GCRev
reviewed
Dec 17, 2024
GCRev
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like were' good to go.
cm421
reviewed
Dec 17, 2024
cm421
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we like the positron.conf commented out, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.