Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve compatibility issue with PHP 8.1 #158

Merged
merged 9 commits into from
Sep 1, 2023
Merged

Resolve compatibility issue with PHP 8.1 #158

merged 9 commits into from
Sep 1, 2023

Conversation

Utsav-Ladani
Copy link
Collaborator

Description

  • This PR resolves the compatibility issue with PHP 8.1
  • The FILTER_SANITIZE_STRING is deprecated in [email protected], so it is replaced with FILTER_SANITIZE_FULL_SPECIAL_CHARS which works same according to PHP docs.

Related issue

@github-actions

This comment was marked as resolved.

Sign in to view
@Utsav-Ladani Utsav-Ladani requested a review from abhishekfdd June 12, 2023 06:56
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

1 similar comment
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

@thelovekesh thelovekesh force-pushed the fix/php-depreciation-error branch from 3b9664a to 8e99359 Compare June 12, 2023 08:04
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

2 similar comments
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

@thelovekesh thelovekesh force-pushed the fix/php-depreciation-error branch from 8516a47 to c7f1532 Compare June 12, 2023 09:26
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

1 similar comment
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

@thelovekesh thelovekesh force-pushed the fix/php-depreciation-error branch from baaba2a to 4fe8b70 Compare June 12, 2023 09:55
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

1 similar comment
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

@thelovekesh thelovekesh force-pushed the fix/php-depreciation-error branch from 3d46ba6 to 4fe8b70 Compare June 12, 2023 10:06
@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

rtBot

This comment was marked as resolved.

Sign in to view

@github-actions
Copy link

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/158/merge/

@Utsav-Ladani
Copy link
Collaborator Author

Hello @abhishekfdd,

I fixed the PHPCS warnings, but the CI test is still failing. How to fix this issue?

NikhilJoshua
NikhilJoshua approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@NikhilJoshua NikhilJoshua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikhilJoshua NikhilJoshua merged commit 13b48a8 into master Sep 1, 2023
@NikhilJoshua NikhilJoshua deleted the fix/php-depreciation-error branch September 1, 2023 08:20
@jesperronn jesperronn mentioned this pull request Dec 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtBot rtBot rtBot left review comments

@NikhilJoshua NikhilJoshua NikhilJoshua approved these changes

@abhishekfdd abhishekfdd Awaiting requested review from abhishekfdd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Utsav-Ladani @NikhilJoshua @rtBot @thelovekesh