Fix tests & fix some special package name #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should accept any ident include protobuf keywords like: rpc, message, package, etc.
ghost
assigned 
|
You also need to account for special names in object references. I have a more complete solution here: https://github.com/xaviershay/ruby-protobuf/compare/fixes (but yours is better than nothing) |
|
@qqshfox and @xaviershay, I'll look into these commits today and get back to you. Thanks for helping out. |
|
I'm closing this pull in favor of the work in #22. I've rewritten the compiler to inherit from libprotoc and this should solve these issues. A new version of the gem will be released soon. Thanks for the submission! |
evanboho
pushed a commit
to evanboho/protobuf
that referenced
this pull request
Mar 2, 2017
Make all errors descend from Protobuf::Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: macks/ruby-protobuf#11, macks/ruby-protobuf#10