-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print warning when running Bundler on potentially problematic RubyGems & Ruby combinations #5177
Conversation
8071b11
to
5b865a4
Compare
Marking as ready, pending the specific copy of the warning to be decided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up! I think this will reduce future support by a lot. 👍🏻
The `BUNDLE_` prefix should be reserved to first class settings that should be listed when running `bundle config`. This one is just a hacky environment variable that has not corresponding documented setting.
…mbinations Co-authored-by: André Arko <[email protected]>
d167c66
to
d6df0b7
Compare
@indirect Good to go now? Feel free to enable auto merge if you are satisfied with this. |
I'm reading the Luckily we recommended a constrained Providing a nice upgrade path for this other issue feels much harder. One idea that comes to mind is to update the warning text to also mention that Another idea would be to keep support for old rubies in rubygems for now, while dropping it in bundler. And of course, the issue needs to be fixed, but the problem is to propagate it to old rubies. |
What was the end-user or developer problem that led to this PR?
Users should move on and stop using old rubies, but we shouldn't abruptly drop support in
bundler
. Although doing this is generally fine to do for gems on minor versions, bundler is a bit special, because many scripts includegem install bundler
commands, and old rubygems versions (which old rubies use by default) didn't have the ability to figure out that the latest bundler does not support the current ruby, so thosegem install bundler
commands will start failing as soon as a version ofbundler
no longer supporting old rubies is released.What is your fix for the problem, implemented in this PR?
In order to make sure people get ready for this, start by printing a warning when
bundler
is run on old rubies, and explain which steps users should be taking.Make sure the following tasks are checked