desktop: Add a windows .msi installer #17335
Conversation
|
ruffle.zip |
|
As discussed on Discord, this installer should probably add a Ruffle shortcut. It can be added to either or both of the Desktop and the Start Menu, but I expect most people will want it to be on the Desktop. |
| @@ -1,4 +1,5 @@ | |||
| // winres.h cannot be included, so define manually | |||
| #define VS_VERSION_INFO 1 | |||
There was a problem hiding this comment.
I'm wondering about these version-related strings in this file (VER_FILEVERSION, VER_PRODUCTVERSION). Are they important? If they are, we should probably set them dynamically based on the version from cargo somehow?
There was a problem hiding this comment.
Yes we should! They're not critical by any means, but it's good practice to set them. It's the windows equivalent of tools giving --version as a standard CLI argument.
There was a problem hiding this comment.
I guess we could set them dynamically in build.rs then. It seems that we can use the macros parameter for that, however I'm unsure how that works and I wasn't able to find any examples. We should also consider parameterizing VER_DEBUG and possibly the year.
|
I don't really like stuff on my desktop, I assume the shortcut is optional? |
|
Updated to add shortcuts, remove EULA screen, added a readme for how to build, and moved to
Unfortunately it's really hard to make optional... :( Can delete it immediately, it won't recreate it. |
|
just for the record, that stinks. would it reappear at any time during an update, or is it only on first install? |
| <?endif?> | ||
|
|
||
| <Package | ||
| Name='Ruffle' |
There was a problem hiding this comment.
Just a nitpick: there are mixed apostrophes (' vs "), we should probably use " everywhere.
|
Made the desktop shortcut optional, and fixed the mime type & feature description |
…n a badly upscaled 64x64 one
I appreciate this |
n0samu
added
A-desktop
this was awful. xml and barely documented schemas... 😭
But this makes an msi as part of the nightly release, which installs ruffle and hints at a file association with swfs.
(It's a hint because windows will likely choose to ignore it if the user already has an association - best case it'll ask the user what they want as their default, the next time they open a swf)
I haven't actually tested the action changes on github, just locally 😓 Hard to test.