avm2: Implement Matrix3D with 2D support only #18888
Merged
+446
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
7473740 to
ac547ca
Compare
cookie-s
changed the title
kjarosh
added
A-avm2
cookie-s
commented
Dec 7, 2024
There was a problem hiding this comment.
This log is taken from Adobe Flash Player 32.
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
ac547ca to
69f6554
Compare
|
#18908 produced Git conflict with this PR and it actually implemented a kind of "2D/3D switch" inside DisplayObject. Rebased and followed its design now. |
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
3 times, most recently
from
a3a3018 to
6417e5f
Compare
|
Rebased. Thanks to #18911 , this PR gets much more slim. |
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
796ced1 to
35413ad
Compare
danielhjacobs
added
the
waiting-on-review
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
35413ad to
236c1cb
Compare
|
Rebased. |
kjarosh
reviewed
Dec 27, 2024
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
2 times, most recently
from
f17cb03 to
019476d
Compare
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
019476d to
af60217
Compare
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
2 times, most recently
from
84492b1 to
04ea44d
Compare
|
Rebased to resolve git conflict. |
| .expect("rawData is not a Vector"); | ||
| let raw_data: Vec<f64> = (0..16) | ||
| .map(|i| -> Result<f64, Error<'gc>> { | ||
| raw_data.get(i, activation)?.coerce_to_number(activation) |
There was a problem hiding this comment.
Instead of coerce_to_number(activation), this could use as_f64()
There was a problem hiding this comment.
Thank you! I just fixed it at 80c77e5
Lord-McSweeney
approved these changes
Jan 17, 2025
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
2 times, most recently
from
a223d93 to
cc432fc
Compare
kjarosh
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
cc432fc to
2f1a130
Compare
Replace stubs for flash.geom.Transform.matrix3D getter/setter with an actual implementation of Matrix3D with limited support. This implementation is just a proxy to the existing 2D matrix implementation. Therefore transformations beyond 2D transformation works differently from the expected result.
Co-authored-by: Kamil Jarosz <[email protected]>
.matrix = A, .matrix = null, then .matrix3D has the info of the matrix A. .matrix3D = A, .matrix3D = null, then .matrix is reset to the identity.
kjarosh
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
2f1a130 to
a21946e
Compare
kjarosh
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry #18810 .
Partially resolves #8033 .
#18810 (comment)
Commits
perspectiveProjection,matrix3Dstubs #18908 : 2D/3D switch ( https://docs.ruffle.rs/en_US/FlashPlatform/reference/actionscript/3/flash/geom/Transform.html#matrix3D ).