-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: Don't unnecessarily duplicate the module for single WASM builds #19198
web: Don't unnecessarily duplicate the module for single WASM builds #19198
Conversation
b571a37
to
7412f57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff looks okay, though I suppose this can be squashed into a single commit. Thank you!
We can remove the copying code from build_wasm.ts now, right? |
Hah, good point, this is only the loading part so far... 😅 |
012e13c
to
ce91845
Compare
Ah, the copying part complains about these:
|
You mean, if it's not copied, then the build complains about it missing? |
|
Those should be pointing to the one that always exists, which is now (we probably should have kept just the name |
ce91845
to
c7dd2e9
Compare
Fixed |
c7dd2e9
to
719b94e
Compare
Thank you! |
No description provided.