avm2: Fix URShift in optimizer and hasnext in interpreter when passed a negative index #19219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
added
A-avm2
adrian17
approved these changes
Jan 14, 2025
Lord-McSweeney
force-pushed
the
avm2-fix-urshift
branch
2 times, most recently
from
0b1bf17 to
1fd0827
Compare
`op_has_next` should push `false`, not `0` when `cur_index` is negative, and Op::URShift should push the uint type in the optimizer, not the int type.
Lord-McSweeney
force-pushed
the
avm2-fix-urshift
branch
from
1fd0827 to
e347eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
op_has_nextshould pushfalse, not0whencur_indexis negative, and Op::URShift should push the uint type in the optimizer, not the int type.