avm2: Access Event.target in dispatchEvent

[Lord-McSweeney]

Like #19127, but clones the Event in EventDispatcher.dispatchEvent instead of events::dispatch_event.

[adrian17]

To be sure, this means the clone logic will never trigger if we (as in, native code) are the ones doing dispatching. I'm assuming we're considering it safe?

Can you please also copy the test from my PR? It test a more real-world case and a getter being hit.

[Lord-McSweeney]

To be sure, this means the clone logic will never trigger if we (as in, native code) are the ones doing dispatching. I'm assuming we're considering it safe?

I tested it- none of the "automatically" dispatched events (addedToStage, enterFrame, etc) are mutable at all, so event handlers can't modify them anyway.

Can you please also copy the test from my PR? It test a more real-world case and a getter being hit.

I was going to ask you :P

[torokati44]

GitHub had a brainfart and thought that a no-op rebase would fail, so I force-pushed the last commit with the same changes, hopefully it will work this time.

[torokati44]

Narrator: It did not.
What the heck?

[torokati44]

Third time's the charm! 🎉
BTW the issue was https://www.githubstatus.com/incidents/78wybrzyv0wf, referencing https://github.com/orgs/community/discussions/149282.