avm2: Store locals on AVM stack instead of per-Activation RegisterSets #19248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm2-locals-stack-2
branch
from
8065408 to
fd7c493
Compare
Lord-McSweeney
added
A-avm2
adrian17
approved these changes
Jan 18, 2025
| @@ -214,23 +175,20 @@ impl<'a, 'gc> Activation<'a, 'gc> { | |||
| let (method, global_object, domain) = script.init(); | |||
|
|
|||
| let num_locals = match method { | |||
| Method::Native { .. } => 0, | |||
| Method::Native { .. } => 1, | |||
There was a problem hiding this comment.
To be sure, is this even reachable?
There was a problem hiding this comment.
The script initializer of the builtins script is a native method, so without this the builtin script fails to initialize
Lord-McSweeney
force-pushed
the
avm2-locals-stack-2
branch
from
06d9f9a to
d780308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up
getlocal/setlocalby about 10%