avm2: Avoid wildcard in op dispatch #19369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
force-pushed
the
avm2-dxns-op-stubs
branch
from
df03a92 to
dde60d0
Compare
Lord-McSweeney
approved these changes
Jan 28, 2025
torokati44
force-pushed
the
avm2-dxns-op-stubs
branch
from
dde60d0 to
f105d95
Compare
torokati44
added
A-avm2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from https://github.com/adrian17/ruffle/tree/avm2-interpreter-loop .
I've seen the wildcard cause the compiler to generate slightly worse code, like extra range checks on the enum discriminant before jumping into the jump table.