Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dhall support #218

Closed
wants to merge 3 commits into from
Closed

Add Dhall support #218

wants to merge 3 commits into from

Conversation

sphw
Copy link

@sphw sphw commented Jul 30, 2021

This PR adds Dhall support using serde_dhall, a native Rust implementation of Dhall. Dhall is a functional configuration language designed to make composition of configuration files easier.

closes #123

Copy link
Member

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Awesome, thanks for your contribution!

In general this looks good. The TODO item could be fixed right away, right?

Also (I tested this because I was not 100% sure whether it would work), the from_dhall_value() function does not need to clone.

Here is a patch for that: matthiasbeyer@7a163a7
And here's another patch you could apply: matthiasbeyer@91dafd1

I guess you can just git pull --ff-only https://github.com/matthiasbeyer/config-rs/ pr-218 if you want to apply these 😄

src/file/format/dhall.rs Outdated Show resolved Hide resolved
@matthiasbeyer
Copy link
Member

Plus, I messed up the formatting (thank god we have CI for that), here's the patch that fixes it: matthiasbeyer@00ed90b

You can of course still use the git pull --ff-only line from above, the patch was pushed to this branch and a git rebase --autosquash -i master will squash the fixup away 😄

Sorry for messing this up...

@sphw sphw force-pushed the add-dhall-support branch from 92bcc9f to 1287767 Compare July 30, 2021 23:40
@sphw
Copy link
Author

sphw commented Jul 30, 2021

@matthiasbeyer Thanks for the timely and thorough review

I integrated all your requested changes and comments, and then squashed them into a single commit. I also fixed the error handling case you mentioned above.

Let me know if you have any other comments

@sphw sphw requested a review from matthiasbeyer July 30, 2021 23:43
Copy link
Member

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

No need to squash things into one commit, though. That only makes reviewing harder. For the next time, then... 😆

@MGlolenstine
Copy link

MGlolenstine commented Dec 6, 2021

I have published a PR that should fix the problems during the build.
All tests should succeed now.

Add dhall support compilation fixes.
@polarathene
Copy link
Collaborator

@matthiasbeyer it looks like this PR is going stale too? The build PR referenced last in Dec 2021 was merged, and no remaining concerns with this PR for being merged?

@matthiasbeyer
Copy link
Member

Yep so there's conflicts and this PR needs rebasing.

@polarathene
Copy link
Collaborator

polarathene commented Oct 4, 2023

Yep so there's conflicts and this PR needs rebasing.

Done: #466

@sphw can update their branch here, otherwise my alternative one should be sufficient if they're unresponsive.

@sphw
Copy link
Author

sphw commented Oct 5, 2023

@polarathene I'm closing in favor of your PR, since this has been sitting for almost 2 years now lol. Thanks so much for helping to push it over the finish line.

@sphw sphw closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format request: Dhall
4 participants